Open
Conversation
Contributor
|
it seems like you haven't added any nanpa changeset files to this PR. if this pull request includes changes to code, make sure to add a changeset, by writing a file to refer to the manpage for more information. |
typester
approved these changes
Mar 11, 2025
Contributor
typester
left a comment
There was a problem hiding this comment.
LGTM on the change itself — thanks 👍
Just wondering: are we okay with dropping compatibility with older systems that don't support glibc 2.34?
Personally, I’m not sure we really need to bump the version yet — is there any specific benefit you have in mind?
Member
|
does this bring about any benefits? as a SDK, it'd be ideal if we are not raising the requirement for OS versions too aggressively. folks in server environments can be slow to update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://github.com/pypa/manylinux
For reference, it seems like Debian 12 glibc is 2.36 by default.
https://packages.debian.org/source/bookworm/glibc
Latest Raspberry PI OS (Bookworm) runs Debian 12