fix: clear pending timeout in AudioSource.close()#639
Open
LautaroPetaccio wants to merge 3 commits intolivekit:mainfrom
Open
fix: clear pending timeout in AudioSource.close()#639LautaroPetaccio wants to merge 3 commits intolivekit:mainfrom
LautaroPetaccio wants to merge 3 commits intolivekit:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 3c58cf8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
AudioSource.captureFrame()schedules asetTimeoutthat callsthis.releaseafter the current queue drains.close()disposed the native handle and setclosed = true, but never cleared the timeout. The callback fires after disposal, referencing freed native state. While not a direct FD leak, it causes use-after-free on the native side that can prevent the handle from being fully released.How
Before disposing the handle in
close(), check for a pendingthis.timeoutand callclearTimeout()+ set it toundefined. This prevents the scheduledreleasecallback from firing after the native handle is freed.