fix: add close() to AudioResampler to release native handle#638
Open
LautaroPetaccio wants to merge 2 commits intolivekit:mainfrom
Open
fix: add close() to AudioResampler to release native handle#638LautaroPetaccio wants to merge 2 commits intolivekit:mainfrom
LautaroPetaccio wants to merge 2 commits intolivekit:mainfrom
Conversation
🦋 Changeset detectedLatest commit: e77258e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
AudioResamplercreates anFfiHandlein its constructor but exposes noclose()ordispose()method. Every resampler instance leaks its native handle for the lifetime of the process. UnlikeAudioSourceandVideoSourcewhich both haveclose()methods, the resampler had no way to release its resources.How
Add a public
close()method that callsthis.#ffiHandle.dispose(), following the same pattern asAudioSource.close()andVideoSource.close().