fix: use_external_ip: false is ignored when turn_servers are configured#4209
Open
majiayu000 wants to merge 1 commit intolivekit:masterfrom
Open
fix: use_external_ip: false is ignored when turn_servers are configured#4209majiayu000 wants to merge 1 commit intolivekit:masterfrom
majiayu000 wants to merge 1 commit intolivekit:masterfrom
Conversation
When use_external_ip is false and turn_servers are configured, the server should not use STUN servers to discover external IPs. Previously, the mediatransportutil library would add default STUN servers for NAT traversal, which caused the server to gather server-reflexive candidates (external IPs) even when use_external_ip was set to false. This fix clears the ICEServers from the WebRTC configuration when both: - use_external_ip is false (user doesn't want external IPs) - turn_servers are configured (relay capability is available) TURN servers provide relay capability without requiring STUN for external IP discovery, so this respects the user's intent to not expose external IPs. Fixes livekit#4095 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]> Signed-off-by: majiayu000 <[email protected]>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4095
Summary
use_external_ip: falseandturn_serversare configuredChanges
pkg/rtc/config.goto clear ICEServers from WebRTC configuration when both conditions are met:use_external_ipis false (user doesn't want external IPs)turn_serversare configured (relay capability available)🤖 Generated with Claude Code