Remove subscription_thread_dispatcher.h from public API

[stephen-derosa]

Overview

subscription_thread_dispatcher.h: SubscriptionThreadDispatcher was never meant to be in the public API.

This moves it to the LIVEKIT_INTERNAL_API and to the src/ folder.

For this change we will create a minor version bump since it was never intended to be in the public API to begin with.

[Copilot]

🟡 Changes recommended

Unresolved critical include and public API issues, plus an invalid include directive, block approval.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This PR moves SubscriptionThreadDispatcher toward the internal API and updates its implementation and Room references.

Changes:

• Adds a source-local dispatcher header.
• Updates implementation and Room include paths.
• Changes the public declaration visibility annotation.

File summaries

File	Summary
src/subscription_thread_dispatcher.h	Adds the internal declaration; uses an outdated 2025 copyright year (moderate, 2 votes).
src/subscription_thread_dispatcher.cpp	Include directive has a trailing period and will not compile (critical, 3 votes).
include/livekit/subscription_thread_dispatcher.h	Remains installed and publicly exposed despite the annotation change (moderate, 2 votes).
include/livekit/room.h	Quoted include resolves to the public header rather than the private copy, breaking the intended migration (critical, 3 votes).

Review details

Suppressed comments (1)

src/subscription_thread_dispatcher.h:84

• This is the header included by subscription_thread_dispatcher.cpp, so LIVEKIT_API here still gives the dispatcher definitions public visibility/export. Changing only the other copy to LIVEKIT_INTERNAL_API does not remove these symbols from the ABI; use the internal annotation consistently (or keep one shared internal declaration).

class LIVEKIT_API SubscriptionThreadDispatcher {

• Files reviewed: 4/4 changed files
• Comments generated: 4
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[devin-ai-integration]

Devin Review found 1 new potential issue.

2 flags not posted on this PR by your GitHub settings — view them in Devin Review. (Configure)