Conversation
|
Ian Lee seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
📝 WalkthroughWalkthroughThe Inworld TTS plugin now sets Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Comment |
618c4b5 to
0595314
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@livekit-plugins/livekit-plugins-inworld/livekit/plugins/inworld/tts.py`:
- Around line 358-359: The unconditional setting of pkt["create"]["autoMode"] =
True (in the TTS packet creation where SentenceTokenizer is used) should be
removed or gated to avoid sending an undocumented field; change this to follow
the existing pattern used for timestampType/applyTextNormalization (only set
autoMode if the corresponding config value is provided/is_given()), or otherwise
remove the line and/or wrap the send in graceful error handling to ignore server
rejections related to unknown fields; update the code around the packet
construction in the TTS send/create logic (the block that references
SentenceTokenizer and pkt["create"]) to implement the conditional check or
removal.
🧹 Nitpick comments (1)
livekit-plugins/livekit-plugins-inworld/livekit/plugins/inworld/tts.py (1)
1081-1086: Gateflush_contextbehind a flag whenautoModeis enabled.Currently,
flush_contextis called after every sentence token. WithautoModeenabled (which is unconditional), the Inworld server handles buffering internally, making per-token flushes redundant and increasing message overhead. Consider gating this behind a flag or removing it entirely in favor of explicit flushes via user input orend_input().
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📥 Commits
Reviewing files that changed from the base of the PR and between 618c4b530c21160498255af0e3a0946c3dd24f04 and 05953141b98c71fab26a65a62ef7b4f6a71fe57d.
📒 Files selected for processing (1)
livekit-plugins/livekit-plugins-inworld/livekit/plugins/inworld/tts.py
🧰 Additional context used
📓 Path-based instructions (1)
**/*.py
📄 CodeRabbit inference engine (AGENTS.md)
**/*.py: Format code with ruff
Run ruff linter and auto-fix issues
Run mypy type checker in strict mode
Maintain line length of 100 characters maximum
Ensure Python 3.9+ compatibility
Use Google-style docstrings
Files:
livekit-plugins/livekit-plugins-inworld/livekit/plugins/inworld/tts.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: unit-tests
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
06d67bd to
dc2e179
Compare
12b3bdf to
ab69b8e
Compare
tinalenguyen
left a comment
There was a problem hiding this comment.
thanks for the PR! are you still unable to sign the CLA?
livekit-plugins/livekit-plugins-inworld/livekit/plugins/inworld/tts.py
Outdated
Show resolved
Hide resolved
fix timestamps cumulation * each generation resets timestamps offset to 1 * should keep timestamps monotonically increasing within an agent turn
ab69b8e to
88090e6
Compare
Doesn't look like so. This comment from CLAassistant also seems weird
|
|
I used to see those when pushing from different devices and I needed to re-authorize my GH account for one, not sure if that's the case here |
auto_mode to be added to config param in a separate PR when word tokenizer and user-controlled manual flushes are supported. For now, auto_mode should enhance quality and naturalness of agent response
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.