Merged
Conversation
Still missing: manual connection, QR-Code support needs to be changed to accomodate both IP versions (preferrably without breaking existing support
This adds the ability to connect be connected from IPv6 addresses. This also fixes the way IP addresses are validated on input. Still currently broken: QR code connection
On devices with support for IPv4 (example: 192.168.1.10) and IPv6 (example: 2a02::1), the code will look like this: warpinator://192.168.1.10:42001/ipv6=2a02%3A%3A1 (%3A is ':') On devices that only do IPv6 but not IPv4, the IPv6 address will be used for the host part in the QR code url: warpinator://[2a02::1]:42001 (brackets indicate IPv6)
Member
Author
|
@slowscript |
Contributor
This splits the shown data for manual connection into two lines, one of which contains the data for IPv4 conenction, the other shows the one for IPv6.
Member
Author
|
That's a good idea. Done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This adds IPv6 support.
There are several cases:
a) both devices can do both IP versions: IPv4 is used for compatibility
b) one device can only do IPv6: IPv6 is used
c) one device can only use IPv4 and the other can only use IPv6: there's nothing to do, since those devices can't communicate with each other.
@slowscript :
The QR code changes a bit:
On devices with support for IPv4 (example: 192.168.1.10) and IPv6 (example: 2a02::1), the code will look like this:
warpinator://192.168.1.10:42001/ipv6=2a02%3A%3A1 (%3A is ':')
On devices that only use IPv6 but not IPv4, the IPv6 address will be used for the host part in the QR code url:
warpinator://[2a02::1]:42001 (brackets indicate IPv6)
On devices that only use IPv4, the QR code doesn't change.