compositor.c: hidden panel windows aren't top#802
Open
jknockel wants to merge 1 commit intolinuxmint:masterfrom
Open
compositor.c: hidden panel windows aren't top#802jknockel wants to merge 1 commit intolinuxmint:masterfrom
jknockel wants to merge 1 commit intolinuxmint:masterfrom
Conversation
Top windows are tracked for the purpose of evaluating whether to unredirect the top window. Prior to this change, systray icon windows could be considered top windows, even in the presence of a fullscreen window. When this occurs, the fullscreen window will never be unredirected, since it is not the top window. When a window is fullscreen, we already hide the panel, including all systray icons. This change ensures that we do not consider such hidden panel windows to ever be top windows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Top windows are tracked for the purpose of evaluating whether to unredirect the top window. Prior to this proposed change, systray icon windows could be considered top windows, even in the presence of a fullscreen window. When this occurs, the fullscreen window will never be unredirected, since it is not the top window.
When a window is fullscreen, we already hide the panel, including all systray icons. This change ensures that we do not consider such hidden panel windows to ever be top windows.
To generate a reproducing systray icon that prevents fullscreen windows from being unredirected:
yad --notification --image="dialog-warning" --text="Systray test"A real-world reproducer is the KeePassXC tray icon.