fix: hide status indicator when title is active#1541
Closed
wjyrich wants to merge 1 commit intolinuxdeepin:masterfrom
Closed
fix: hide status indicator when title is active#1541wjyrich wants to merge 1 commit intolinuxdeepin:masterfrom
wjyrich wants to merge 1 commit intolinuxdeepin:masterfrom
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the dock task manager app item so the status indicator in Efficient display mode is hidden whenever the window title is active, by tightening the QML visibility condition. Flow diagram for status indicator visibility conditionflowchart TD
A[root.displayMode === Dock.Efficient] -->|true| B[root.windows.length > 0]
A -->|false| E[Status indicator hidden]
B -->|false| E[Status indicator hidden]
B -->|true| C[!root.titleActive]
C -->|true| D[Status indicator visible]
C -->|false| E[Status indicator hidden]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider extracting the
visibleexpression into a named property or computed alias (e.g.,root.showStatusIndicator) to make the visibility logic easier to read and reuse if similar conditions are needed elsewhere. - It may be worth double-checking whether
root.titleActivefully captures all cases where the status indicator should be hidden (e.g., focus changes from keyboard vs mouse) and whether additional state flags (like window urgency) should override this condition.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider extracting the `visible` expression into a named property or computed alias (e.g., `root.showStatusIndicator`) to make the visibility logic easier to read and reuse if similar conditions are needed elsewhere.
- It may be worth double-checking whether `root.titleActive` fully captures all cases where the status indicator should be hidden (e.g., focus changes from keyboard vs mouse) and whether additional state flags (like window urgency) should override this condition.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
18202781743
approved these changes
Apr 1, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
18202781743
reviewed
Apr 1, 2026
| height: root.statusIndicatorSize | ||
| anchors.centerIn: iconContainer | ||
| visible: root.displayMode === Dock.Efficient && root.windows.length > 0 | ||
| visible: root.displayMode === Dock.Efficient && root.windows.length > 0 && !root.titleActive |
Contributor
There was a problem hiding this comment.
是拆分模式下所有item都不显示这个还是说针对单个item呀,
|
TAG Bot New tag: 2.0.35 |
|
TAG Bot New tag: 2.0.36 |
The status indicator was incorrectly showing when the title was active in Efficient display mode. This fix adds a condition to hide the status indicator when `root.titleActive` is true, ensuring the indicator only appears when appropriate. Log: Fixed status indicator visibility issue in dock task manager Influence: 1. Test dock task manager in Efficient display mode 2. Verify status indicator hides when window title is active 3. Check status indicator shows correctly when title is not active 4. Test with multiple windows open 5. Verify behavior across different display modes fix: 修复状态指示器在标题激活时错误显示的问题 状态指示器在高效显示模式下标题激活时错误显示。此修复添加了当 `root.titleActive` 为 true 时隐藏状态指示器的条件，确保指示器只在适当的 时候显示。 Log: 修复了任务管理器中状态指示器可见性问题 Influence: 1. 在高效显示模式下测试任务管理器 2. 验证状态指示器在窗口标题激活时隐藏 3. 检查状态指示器在标题未激活时正确显示 4. 测试多个窗口打开的情况 5. 验证不同显示模式下的行为
wjyrich
force-pushed
the
fix-UIWithBackground
branch
from
db3fc05 to
163cd0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The status indicator was incorrectly showing when the title was active in Efficient display mode. This fix adds a condition to hide the status indicator when
root.titleActiveis true, ensuring the indicator only appears when appropriate.Log: Fixed status indicator visibility issue in dock task manager
Influence:
fix: 修复状态指示器在标题激活时错误显示的问题
状态指示器在高效显示模式下标题激活时错误显示。此修复添加了当
root.titleActive为 true 时隐藏状态指示器的条件，确保指示器只在适当的时候显示。
Log: 修复了任务管理器中状态指示器可见性问题
Influence:
Summary by Sourcery
Bug Fixes: