feat: fix notification center height calculation for bottom dock#1540
feat: fix notification center height calculation for bottom dock#1540wjyrich merged 1 commit intolinuxdeepin:masterfrom
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideAdjusts the notification center’s height calculation for bottom-docked panels to use the actual visible screen space instead of a fixed dock size, preventing the notification center from extending beyond the screen. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider adding a short comment explaining the
visibleHeightcalculation (whyMath.max(0, screenGeometry.y + screenGeometry.height - dockGeometry.y)is needed) to make the intent clear for future maintainers. - If other dock positions (e.g., top) need similar visible-area-based sizing, consider extracting a small helper for visible dimension calculation to keep the layout logic consistent and avoid duplicating geometry math.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding a short comment explaining the `visibleHeight` calculation (why `Math.max(0, screenGeometry.y + screenGeometry.height - dockGeometry.y)` is needed) to make the intent clear for future maintainers.
- If other dock positions (e.g., top) need similar visible-area-based sizing, consider extracting a small helper for visible dimension calculation to keep the layout logic consistent and avoid duplicating geometry math.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: 18202781743, wjyrich The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
TAG Bot New tag: 2.0.35 |
|
TAG Bot New tag: 2.0.36 |
a83fcba to
7adc530
Compare
1. Fixed height calculation for notification center when dock is positioned at bottom 2. Changed from using static dockSize to dynamic calculation based on visible screen space 3. Added logic to calculate visible height between dock top and screen bottom 4. Ensures notification center doesn't extend beyond visible screen area Log: Fixed notification center display issue when dock is at bottom of screen Influence: 1. Test notification center with dock positioned at bottom of screen 2. Verify notification center height adapts correctly to screen boundaries 3. Test with multiple screen configurations and resolutions 4. Verify notification center doesn't extend beyond visible screen area 5. Test with dock at different positions (left, right, top) to ensure no regression feat: 修复底部停靠栏时通知中心高度计算问题 1. 修复当停靠栏位于底部时通知中心的高度计算问题 2. 从使用静态dockSize改为基于可见屏幕空间的动态计算 3. 添加计算停靠栏顶部到屏幕底部可见高度的逻辑 4. 确保通知中心不会超出可见屏幕区域 Log: 修复停靠栏位于屏幕底部时通知中心显示问题 Influence: 1. 测试停靠栏位于屏幕底部时的通知中心显示 2. 验证通知中心高度是否正确适应屏幕边界 3. 测试多种屏幕配置和分辨率下的表现 4. 验证通知中心不会超出可见屏幕区域 5. 测试停靠栏在不同位置(左、右、顶部)确保没有回归问题 PMS: BUG-353613 T#
Log: Fixed notification center display issue when dock is at bottom of screen
Influence:
feat: 修复底部停靠栏时通知中心高度计算问题
Log: 修复停靠栏位于屏幕底部时通知中心显示问题
Influence:
PMS: BUG-353613
T#
Summary by Sourcery
Bug Fixes: