fix: fix notification bubble animation glitch by mhduiy · Pull Request #1537 · linuxdeepin/dde-shell

mhduiy · 2026-03-30T02:48:08Z

Replaced the previous complex ScriptAction with a simpler PropertyAnimation for the add transition
Added a new addDisplaced transition to handle displaced items when new notifications are added
Removed the manual script that forced previous bubble animations to complete, which was causing visual glitches
Now uses standard Qt Quick transitions for smoother and more reliable animation behavior

fix: 修复通知气泡动画显示问题

将之前复杂的 ScriptAction 替换为更简单的 PropertyAnimation 来处理添加动画
新增 addDisplaced 过渡动画来处理新通知添加时其他气泡的位移
移除了强制完成前一个气泡动画的手动脚本，该脚本会导致视觉故障
现在使用标准的 Qt Quick 过渡动画来实现更平滑可靠的动画效果

PMS: BUG-355029

Summary by Sourcery

Simplify and standardize notification bubble list transitions to fix animation glitches when new notifications are added.

Bug Fixes:

Resolve visual glitches caused by forcibly completing previous notification bubble animations when adding new notifications.

Enhancements:

Replace the previous ScriptAction and XAnimator-based add transition with a single PropertyAnimation-based transition for smoother bubble entry.
Introduce an addDisplaced transition using PropertyAnimation to smoothly reposition existing bubbles when new notifications are inserted.

sourcery-ai · 2026-03-30T02:48:32Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Refactors the notification bubble list add animation to use standard Qt Quick PropertyAnimation transitions, and adds a dedicated addDisplaced transition to smoothly reposition existing bubbles when new notifications are inserted, removing the previous manual ScriptAction hack that caused glitches.

Sequence diagram for updated notification bubble add animation

sequenceDiagram
    actor User
    participant App
    participant NotificationModel
    participant bubbleView
    participant addTrans
    participant addDisplacedTrans

    User->>App: Triggers event that creates notification
    App->>NotificationModel: appendNotification()
    NotificationModel-->>bubbleView: modelUpdated (new item)
    bubbleView->>addTrans: start add Transition
    activate addTrans
    addTrans->>addTrans: PropertyAnimation on item.x
    addTrans-->>bubbleView: item slides in from width to 0
    deactivate addTrans

    bubbleView->>addDisplacedTrans: start addDisplaced Transition
    activate addDisplacedTrans
    addDisplacedTrans->>addDisplacedTrans: PropertyAnimation on displaced items x
    addDisplacedTrans-->>bubbleView: existing bubbles reposition smoothly
    deactivate addDisplacedTrans

File-Level Changes

Change	Details	Files
Replace custom ScriptAction/XAnimator-based add animation with a simple PropertyAnimation on x.	Remove the ScriptAction that forcibly completes the previous bubble’s animation by setting its x position to 0. Replace the XAnimator used in the add Transition with a PropertyAnimation targeting the added item’s x property. Animate the added item from its own width to x = 0 over 600ms with an OutExpo easing curve.	`panels/notification/bubble/package/main.qml`
Introduce an addDisplaced Transition to smoothly animate repositioned bubbles when new notifications are added.	Add an addDisplaced Transition block on the ListView to handle displacement of existing items. Within addDisplaced, add a PropertyAnimation targeting the displaced item’s x property, animating it to 0. Use the same 600ms OutExpo easing as the add animation for consistent motion between added and displaced bubbles.	`panels/notification/bubble/package/main.qml`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

18202781743 · 2026-04-02T02:16:52Z

frame/layershell/x11dlayershellemulation.cpp

+
+    int targetWidth = m_window->width();
+    int targetHeight = m_window->height();
+    if (m_dlayerShellWindow->geometryManagedByBackend()) {


geometryManagedByBackend 这个属性应该可以不用外面设置吧,当存在preferredWidth这些的时候,取preferredWidth, 这个逻辑可以封装到layershell内部,跟qt类似,

wayland 我没有试过, 可能不存在这个问题. 所以这个属性暴露出来是为了就算是绑定了preferredWidth也可以选择不使用,是一种兼容性处理

18202781743 · 2026-04-02T02:17:37Z

@caimc123456

deepin-ci-robot · 2026-04-02T11:33:43Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: 18202781743, mhduiy

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

debian/deepin/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

deepin-bot · 2026-04-07T09:22:36Z

TAG Bot

New tag: 2.0.35
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1545

deepin-bot · 2026-04-07T13:11:30Z

TAG Bot

New tag: 2.0.36
DISTRIBUTION: unstable
Suggest: synchronizing this PR through rebase #1547

1. Replaced the previous complex ScriptAction with a simpler PropertyAnimation for the add transition 2. Added a new addDisplaced transition to handle displaced items when new notifications are added 3. Removed the manual script that forced previous bubble animations to complete, which was causing visual glitches 4. Now uses standard Qt Quick transitions for smoother and more reliable animation behavior fix: 修复通知气泡动画显示问题 1. 将之前复杂的 ScriptAction 替换为更简单的 PropertyAnimation 来处理添加动画 2. 新增 addDisplaced 过渡动画来处理新通知添加时其他气泡的位移 3. 移除了强制完成前一个气泡动画的手动脚本，该脚本会导致视觉故障 4. 现在使用标准的 Qt Quick 过渡动画来实现更平滑可靠的动画效果 PMS: BUG-355029

mhduiy · 2026-04-08T02:04:22Z

/forcemerge

deepin-bot · 2026-04-08T02:04:36Z

This pr force merged! (status: blocked)

sourcery-ai bot reviewed Mar 30, 2026

View reviewed changes

18202781743 previously approved these changes Mar 30, 2026

View reviewed changes

mhduiy dismissed 18202781743’s stale review via b9266de April 2, 2026 01:35

mhduiy force-pushed the animation branch from 4c5f485 to b9266de Compare April 2, 2026 01:35

18202781743 reviewed Apr 2, 2026

View reviewed changes

18202781743 requested a review from BLumia April 2, 2026 02:17

mhduiy force-pushed the animation branch 2 times, most recently from 9ea5674 to 93acc3d Compare April 2, 2026 08:13

18202781743 approved these changes Apr 2, 2026

View reviewed changes

mhduiy force-pushed the animation branch from 93acc3d to 740de9e Compare April 8, 2026 02:04

deepin-bot bot merged commit 1d340e6 into linuxdeepin:master Apr 8, 2026
9 of 12 checks passed

Conversation

mhduiy commented Mar 30, 2026 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai bot commented Mar 30, 2026

Reviewer's Guide

Sequence diagram for updated notification bubble add animation

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

18202781743 Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mhduiy Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

18202781743 commented Apr 2, 2026

Uh oh!

deepin-ci-robot commented Apr 2, 2026

Uh oh!

deepin-bot bot commented Apr 7, 2026

Uh oh!

deepin-bot bot commented Apr 7, 2026

Uh oh!

mhduiy commented Apr 8, 2026

Uh oh!

deepin-bot bot commented Apr 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mhduiy commented Mar 30, 2026 •

edited by sourcery-ai bot

Loading

18202781743 Apr 2, 2026 •

edited

Loading