init: make sure config.user is overriden only with new values so that going DEBUG/undoing can work reproducibly#1772
Merged
tlaurion merged 1 commit intolinuxboot:masterfrom Sep 2, 2024
Conversation
… going DEBUG/undoing can work reproducibly Signed-off-by: Thierry Laurion <insurgo@riseup.net>
2 tasks
Collaborator
Author
|
Merging as tested as well under #1773 thoroughly. This is actually a bugfix. Merging without needing review. There i absolutely no good reason for having those entries multiple times, fused in and injected under CBFS as on master. Merging bypassing review process. |
Collaborator
JonathonHall-Purism
left a comment
JonathonHall-Purism
left a comment
There was a problem hiding this comment.
Thanks for this change, agree 100%. Sorry for the delay looking over this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of today, somone deciding to Config -> Enable DEBUG + flash cannot simply go back to Config-> Disable DEBUG + flash and have its system permit unsealing previous TPMTOTP + TPM DUK and go on.
This fixes config.user being injected over and over the same TPM related settings by making sure they are not preent prior of reinjectig them.