Skip to content

fabrics: avoid segfault at sanitize_discovery_log_entry() #3376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
martin-gpy wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −0
Open

fabrics: avoid segfault at sanitize_discovery_log_entry() #3376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions libnvme/src/nvme/fabrics.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1490,6 +1490,9 @@ static int nvme_discovery_log(libnvme_ctrl_t ctrl,
static void sanitize_discovery_log_entry(struct libnvme_global_ctx *ctx,
struct nvmf_disc_log_entry *e)
{
if (!e)
return;
Copy link
Copy Markdown
Collaborator

@igaw igaw May 28, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you observe a crash? I don't see how this is potential possible. All call side pass in &log->entries[i]. So this will be always a pointer value which is != NULL.

I don't mind starting to sanity check the log page input (all input is evil) but this seems at the wrong place.


strchomp(e->trsvcid, sizeof(e->trsvcid));
strchomp(e->traddr, sizeof(e->traddr));

Expand Down
Loading