nvme-print-json: delete nvme list verbose v1 version output#2990
Open
ikegami-t wants to merge 1 commit intolinux-nvme:masterfrom
Open
nvme-print-json: delete nvme list verbose v1 version output#2990ikegami-t wants to merge 1 commit intolinux-nvme:masterfrom
ikegami-t wants to merge 1 commit intolinux-nvme:masterfrom
Conversation
ikegami-t
force-pushed
the
output-format-v2
branch
from
41c026a to
616159f
Compare
Contributor
Author
|
Just rebased with the master. |
Collaborator
|
I would like to keep the version output around because when we remove it, we will break existing users without any need. The v1 code doesn't hurt at this moment. Would I suggest is that we can change the default version. In this case we give the users the possibility to still use the older versions but they have to select it active. And with this we might convince them to update their code around nvme-cli output. |
Contributor
Author
|
Yes good idea so will change the default version to two for now. Thank you. |
To update nvme-cli output version 2 only in future. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
ikegami-t
force-pushed
the
output-format-v2
branch
from
616159f to
adf7f67
Compare
Contributor
Author
|
Just updated the patch to change the default output format version to 2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to output the version 2 output only.