Skip stale fs store artifacts#4618
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
benthecarman
force-pushed
the
fix-fs-store-list-artifacts
branch
from
132d9cc to
190e458
Compare
|
Good — the I've completed a thorough review of this PR. The changes are correct. My prior review already confirmed no issues, and this re-review concurs. No issues found. |
benthecarman
force-pushed
the
fix-fs-store-list-artifacts
branch
from
190e458 to
4a1affd
Compare
|
Please word-wrap your commit messages. |
The exhaustive filesystem store listing treated leftover temp and trash files as namespace directories after identifying them as non-keys. Skip those artifacts before recursing so migrations can ignore crash leftovers.
benthecarman
force-pushed
the
fix-fs-store-list-artifacts
branch
from
4a1affd to
1b5475a
Compare
|
I'm confused, do we ever actually write |
|
We're not creating/using tmp directories. The problem is we'd skip over tmp/trash files and then later think they were dirs (because they weren't keys) and try to go into it as if it were a dir |
| { | ||
| // Clean up any trash files lying around. | ||
| if ext == "trash" { | ||
| if p.extension().and_then(|ext| ext.to_str()) == Some("trash") { |
There was a problem hiding this comment.
We've ended up short-circuiting this behavior, should we retain it (what are trash files anyway?)
There was a problem hiding this comment.
According to Claude trash files don't ever show up in windows so not really sure what this is meant for
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4618 +/- ##
==========================================
+ Coverage 86.42% 86.53% +0.11%
==========================================
Files 158 159 +1
Lines 109324 109856 +532
Branches 109324 109856 +532
==========================================
+ Hits 94484 95068 +584
+ Misses 12300 12263 -37
+ Partials 2540 2525 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4 participants
The exhaustive filesystem store listing treated leftover temp and trash files as namespace directories after identifying them as non-keys. Skip those artifacts before recursing so migrations can ignore crash leftovers.
Caught by codex here: lightningdevkit/ldk-node#872 (comment)