Update ldk-node dependency & expose bolt12 proofs - #258
Conversation
|
👋 Thanks for assigning @tankyleo as a reviewer! |
c41e3d8 to
a0b2517
Compare
|
Rebased and updated ldk-node to new commit with the pagination changes. Now using the paginated payments instead of the ldk-server version |
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Looks good, but we should probably also include the new channel type in list_channels now.
a0b2517 to
1a3344b
Compare
1a3344b to
9346952
Compare
Adapt payment events to the updated ldk-node API and expose their payment IDs. Continue to handle unknown BOLT 11 payments manually so the receive-for-hash APIs work correctly. AI assistance: OpenAI Codex was used for this change.
9346952 to
6076c50
Compare
| | NodeError::GossipUpdateTimeout | ||
| | NodeError::LiquiditySourceUnavailable | ||
| | NodeError::LiquidityRequestFailed | ||
| | NodeError::PayerProofCreationFailed |
There was a problem hiding this comment.
Codex wants to classify this to an InvalidRequestError rather than an InternalServerError. It's not perfect, but seems InvalidRequestError is more likely if we hit PayerProofCreationFailed
There was a problem hiding this comment.
Yeah not perfect mapping, but fixed
Add payer-proof creation to the gRPC, CLI, and MCP interfaces. Include the preimage and invoice in successful-payment events because stateless proof creation requires both values. AI assistance: OpenAI Codex was used to rebase and verify this change.
Read payment pages directly from ldk-node so the server does not store duplicate payment records. Keep the server database for forwarded-payment history. AI assistance: OpenAI Codex was used for this change.
6076c50 to
29b7174
Compare
tankyleo
left a comment
tankyleo
left a comment
There was a problem hiding this comment.
I asked Codex to cast a broader net, here's what it found, feel free to dismiss aggressively, but all seemed worth taking a look to me.
AI assistance: OpenAI Codex was used for this change.
AI assistance: OpenAI Codex was used for this change.
AI assistance: OpenAI Codex was used for this change.
|
Also confirmed this patch now keeps my fans quiet on mainnet |
4 participants
Update ldk-node and adapt payment events to its current API. Expose payment IDs in events and retain manual handling for unknown BOLT 11 payments.
Add BOLT 12 payer-proof creation to the gRPC, CLI, and MCP interfaces. Include the preimage and invoice in successful-payment events for stateless proof creation.
Use ldk-node pagination for payment history. Remove duplicate payment records from the ldk-server SQLite store, which now contains only forwarded-payment history.