Fix flaky async_payment test due to non-deterministic event ordering#799
Merged
tnull merged 1 commit intolightningdevkit:mainfrom Feb 20, 2026
Merged
Conversation
node_sender_lsp and node_receiver_lsp each have two channels, so they receive two ChannelReady events whose order depends on timing. The test previously consumed these events in a fixed order, which could fail when the events arrive in the opposite order. Reproduced locally by swapping the assertion order at line 1346-1347, which fails deterministically since the "normal" local ordering is the opposite of the one expected by the swapped assertions. Add an expect_channel_ready_events\! macro that consumes two ChannelReady events and asserts both expected counterparties are present regardless of arrival order. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
👋 Thanks for assigning @tnull as a reviewer! |
tnull
approved these changes
Feb 20, 2026
|
|
||
| pub(crate) use expect_channel_ready_event; | ||
|
|
||
| macro_rules! expect_channel_ready_events { |
Collaborator
There was a problem hiding this comment.
nit: Could have named it expect_two_channel_ready_events.
Contributor
Author
There was a problem hiding this comment.
yes, would've been better
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
node_sender_lsp and node_receiver_lsp each have two channels, so they receive two ChannelReady events whose order depends on timing. The test previously consumed these events in a fixed order, which could fail when the events arrive in the opposite order.
Reproduced locally by swapping the assertion order at line 1346-1347, which fails deterministically since the "normal" local ordering is the opposite of the one expected by the swapped assertions.
Add an expect_channel_ready_events! macro that consumes two ChannelReady events and asserts both expected counterparties are present regardless of arrival order.
Fixes #798