Skip to content

The scrypt Password-Based Key Derivation Function (RFC 7914)#719

Merged
sjaeckel merged 1 commit intodevelopfrom
pr/scrypt-rfc7914
Apr 14, 2026
Merged

The scrypt Password-Based Key Derivation Function (RFC 7914)#719
sjaeckel merged 1 commit intodevelopfrom
pr/scrypt-rfc7914

Conversation

@karel-m
Copy link
Copy Markdown
Member

@karel-m karel-m commented Apr 11, 2026

Implementation of scrypt (in the end, quite a short piece of code, as I was able to reuse existing parts of libtomcrypt).

Follows RFC 7914 https://www.rfc-editor.org/rfc/rfc7914.html

Checklist

  • documentation is added or updated
  • tests are added or updated

@karel-m karel-m requested a review from sjaeckel April 11, 2026 16:48
@karel-m
Copy link
Copy Markdown
Member Author

karel-m commented Apr 11, 2026

Sorry, my pr/scrypt-rfc7914 branch was not based on develop, but on pr/argon2-rfc9106.

I will leave it as it is for now so that we have CI build/test results, but it must be rebased before merging.

@sjaeckel sjaeckel changed the base branch from develop to pr/argon2-rfc9106 April 12, 2026 14:09
@sjaeckel sjaeckel force-pushed the pr/scrypt-rfc7914 branch from 903b507 to 9fb1967 Compare April 12, 2026 14:10
@karel-m
Copy link
Copy Markdown
Member Author

karel-m commented Apr 12, 2026

Not sure whether it would not be better to name the function scrypt_pbkdf(..) instead of just scrypt(..)

Base automatically changed from pr/argon2-rfc9106 to develop April 13, 2026 08:47
@sjaeckel
Copy link
Copy Markdown
Member

Not sure whether it would not be better to name the function scrypt_pbkdf(..) instead of just scrypt(..)

I like that, I think this should be renamed.

Copy link
Copy Markdown
Member

@sjaeckel sjaeckel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

Basically LGTM, besides that one question, but I'd also be happy to take this as is :)

Please also squash all those commits into one.

@sjaeckel sjaeckel force-pushed the pr/scrypt-rfc7914 branch from 893baad to 39febe0 Compare April 14, 2026 08:26
@sjaeckel sjaeckel force-pushed the pr/scrypt-rfc7914 branch from 39febe0 to 3aed12c Compare April 14, 2026 11:59
@sjaeckel sjaeckel merged commit e5bfb94 into develop Apr 14, 2026
246 checks passed
@sjaeckel sjaeckel deleted the pr/scrypt-rfc7914 branch April 14, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants