Draft
Conversation
Open
* Unify tests into one implementation. * Re-factor `s_sha1_is_supported()` which simplifies this quite a bit. * Improve the pattern where choosing which implementation to run in `sha1_desc.c`. * Only register the common descriptor in `register_all_hashes()`. * Some other minor fixes/improvements. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
sjaeckel
reviewed
Apr 13, 2026
Fix matching of other uses of a descriptor type, besides their declaration.
Open
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Since there's absolutely no way to ensure that a struct is somehow aligned -- all those compile-time mechanism are best-effort and no guarantee -- we align the necessary buffers at run-time. AES-NI already introduced that, let's improve a bit upon its usage. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
* we try to keep ifdef's at one place * the last real x86 was launched in 2007, while the SHA instructions were only introduced in 2013, so IMO we can safely assume that there's no need to handle non-x86-64 instruction sets. * some minor fixes Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
* we try to keep ifdef's at one place * the last real x86 was launched in 2007, while the SHA instructions were only introduced in 2013, so IMO we can safely assume that there's no need to handle non-x86-64 instruction sets. * some minor fixes Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Member
|
FYI: Please feel free to read the commit messages of the commits I added, they contain the reasoning behind most of the changes. |
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Allow more classes to be filtered. Signed-off-by: Steffen Jaeckel <s@jaeckel.eu> (cherry picked from commit 14352f5)
Member
|
Looking at the results in appveyor it seems like this somehow doesn't result in any improvements on MSVC ... |
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
Signed-off-by: Steffen Jaeckel <s@jaeckel.eu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP - there are still things that need to be resolved, see #716.