Relax some find_neighbors() assertions that can be overzealous for 1D Elems#3853
Open
jwpeterson wants to merge 5 commits intolibMesh:develfrom
Open
Relax some find_neighbors() assertions that can be overzealous for 1D Elems#3853jwpeterson wants to merge 5 commits intolibMesh:develfrom
jwpeterson wants to merge 5 commits intolibMesh:develfrom
Conversation
|
Job Test MOOSE clang on efdaf92 : invalidated by @jwpeterson Unrelated failure of time_steppers/time_adaptive.test |
Member
Author
Ah, I think the failures I'm seeing from the unit tests are due to using a netCDF-4/HDF5 exo file... I think there is a way to convert it to something more portable to our CI, I just need to remember what that is... |
Member
|
IIRC you can use h5dump to get ASCII out of the ExodusII-HDF5 file and pipe that to ncgen to put it into an ExodusII-NetCDF3 file. |
To do the conversion, first ncdump the file to text: ncdump foo.e > foo.txt Then ncgen with the -k '64-bit offset' option: ncgen foo.txt -k '64-bit offset' -o foo.e If not already in your PATH, the ncgen utility can be found in your libMesh build directory: $LIBMESH_BUILD/contrib/netcdf/v4/ncgen/ncgen
Member
Author
I used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think it will be easy to make #3851 work correctly in the short term, so this PR takes a different approach which is basically to just allow incomplete/incorrect neighbor information on meshes with multiple 1D Elems meeting in a single Node. To be clear, we were already doing this so the PR doesn't make it any worse, but we did have some overzealous asserts in
find_neighbors()which are currently being tripped when refining such meshes.