Conversation
|
@jameskermode I think I need you to add the secrets here for the docker login. Then other actions that will build the other images will use that secret as well. |
|
Unfortunately I don’t have the secrets as I was never responsible for the Docker hub account. This was probably done by Adam Fekete, if he is still reachable somewhere. |
|
Dockerfile looks good to me. Not sure how this should fit into the rest of the build hierarchy, maybe we don’t need all those images anymore. |
|
I see, let me bug them. Though @gabor1 surely has the login |
|
Then we can tinker a little to speed up the build of those, because docker is very good at caching and we can pull the latest version of the image and build only the changes on top of it |
|
moreover, we will need to change the trigger, just before merging this, since now it builds them on every commit |
- simple command - speed up build with caching
now explicitly setting the image to cache from
|
the failing build is due to missing f90wrap from the source directory, changed at the PyPi release: |
source is not there at all
|
Why don’t we change it to pip install rather than build? |
|
We could change it to that for the one that is used in python, but we need to build the serial one for lammps and others. I also suggest moving this workflow over to QUIP entirely and archiving this repo. GitHub Actions can do jobs longer than an hour and detection of a job succeeding, being on the correct branch, etc. is easy enough so that there is no need for a ping from there to here. |
|
The only problem with the pip install may be that the version of QUIP may differ from the serial one installed, since the PyPI updates when we change the pinned version in quippy-wheels |
|
Yeah, makes sense .
…-- Gábor
On 27 Jun 2021, at 00:47, Tamas Stenczel ***@***.***> wrote:
The only problem with the pip install may be that the version of QUIP may differ from the serial one installed, since the PyPI updates when we change the pinned version in quippy-wheels
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
is this ready to be merged? |
4 participants
CI on github actions for building the images