Add CategoryIcon component and exports#1503
Merged
leecalcote merged 3 commits intolayer5io:masterfrom May 7, 2026
Merged
Conversation
Contributor
Author
|
@rishiraj38 review the PR |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new CategoryIcon component and integrates it into the icons library. The review feedback suggests improving maintainability by reusing the existing CustomIconProps type and resolving a redundant dual export in the component's index file to prevent potential name collisions.
Member
|
Thanks, @NSTKrishna. Be sure to respond to all feedback comments. |
Introduce a new CategoryIcon SVG component (src/icons/CategoryIcon/CategoryIcon.tsx) that accepts width, height, primaryFill, secondaryFill, and style, using theme defaults and constants for sizing and color fallbacks. Add an index re-export for the component (src/icons/CategoryIcon/index.tsx) and update the top-level icons barrel (src/icons/index.ts) to export CategoryIcon. Signed-off-by: NSTKrishna <krishnagehlot936@gmail.com>
Replace local CategoryIconProps and IconProps import with shared CustomIconProps in CategoryIcon.tsx, simplifying prop typing and unifying with other icons. Remove default export from CategoryIcon (now only named export). Update index.tsx to export the named CategoryIcon only and remove the redundant default export line. Minor cleanup: remove trailing newline in index file. Signed-off-by: NSTKrishna <krishnagehlot936@gmail.com>
NSTKrishna
force-pushed
the
feat/add-category-icon
branch
from
1a65a02 to
376d3de
Compare
Contributor
Author
|
@leecalcote I resolve the all feedback comments and kindly review the pr |
rishiraj38
suggested changes
May 7, 2026
Co-authored-by: Rishi Raj <180109771+rishiraj38@users.noreply.github.com> Signed-off-by: Krishna Gehlot <krishnagehlot936@gmail.com>
leecalcote
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new CategoryIcon SVG component (src/icons/CategoryIcon/CategoryIcon.tsx) that accepts width, height, primaryFill, secondaryFill, and style, using theme defaults and constants for sizing and color fallbacks. Add an index re-export for the component (src/icons/CategoryIcon/index.tsx) and update the top-level icons barrel (src/icons/index.ts) to export CategoryIcon.
Notes for Reviewers
This PR fixes #1490
Signed commits