Skip to content

feat(schemas): re-export helpAndSupportModal schemas from @meshery/schemas (closes #866)#1494

Merged
mascot-five merged 1 commit intomasterfrom
feat/helpandsupport-schema-from-meshery-schemas
May 6, 2026
Merged

feat(schemas): re-export helpAndSupportModal schemas from @meshery/schemas (closes #866)#1494
mascot-five merged 1 commit intomasterfrom
feat/helpandsupport-schema-from-meshery-schemas

Conversation

@leecalcote
Copy link
Copy Markdown
Member

Summary

  • Replaces the hand-authored helpAndSupportModalSchema and helpAndSupportModalUiSchema with canonical re-exports from @meshery/schemas@1.2.11 (SupportRequestRjsfSchemaV1Beta1 / SupportRequestRjsfUiSchemaV1Beta1).
  • Bumps devDependencies["@meshery/schemas"] from 1.2.9 to 1.2.11 (pinned exact, matching the pattern from commit b8c7a204).
  • Regenerates package-lock.json to reflect the version bump.
  • Completes the full migration of all sistent RJSF form schemas to @meshery/schemas as the canonical source (Move hand-authored RJSF form schemas from layer5io/sistent to canonical @meshery/schemas meshery/schemas#866).

Bug fixed

The hand-authored schema had default: 'Technical' on the scope field, but 'Technical' is not a member of the declared enum: ['Support', 'Community', 'Account', 'Commercial']. The canonical schema from @meshery/schemas omits this invalid default, resolving a latent RJSF validation inconsistency.

Related

Test plan

  • npm install completes cleanly (lockfile updated)
  • All 18 test suites pass (verified locally: 50 tests, 0 failures)
  • src/schemas/index.tsx continues to export helpAndSupportModalSchema and helpAndSupportModalUiSchema as default re-exports (no consumer-side changes required)
  • Help and Support modal renders correctly in Meshery UI with the canonical schema fields: subject, message, scope (radio widget)

…loses #866)

Migrates helpAndSupportModalSchema / helpAndSupportModalUiSchema from
hand-authored inline definitions to canonical re-exports from
@meshery/schemas@1.2.11 (SupportRequestRjsfSchemaV1Beta1 /
SupportRequestRjsfUiSchemaV1Beta1).

This completes the full migration of all sistent RJSF form schemas to
@meshery/schemas as the canonical source per meshery/schemas#866.

Also fixes a latent bug: the prior default 'Technical' was not a member
of enum ['Support','Community','Account','Commercial']; the canonical
schema omits the invalid default.

Signed-off-by: Lee Calcote <leecalcote@gmail.com>
Copilot AI review requested due to automatic review settings May 6, 2026 13:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR completes the migration of the helpAndSupportModal RJSF assets in Sistent to use the canonical schema/UI schema exports from @meshery/schemas, eliminating drift (including the previously invalid scope default) while keeping Sistent’s public export surface unchanged.

Changes:

  • Replace hand-authored helpAndSupportModal schema + UI schema with canonical re-exports (SupportRequestRjsfSchemaV1Beta1 / SupportRequestRjsfUiSchemaV1Beta1) from @meshery/schemas.
  • Bump @meshery/schemas from 1.2.9 to 1.2.11.
  • Regenerate package-lock.json for the dependency bump.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
src/schemas/helpAndSupportModal/schema.tsx Swaps local object literal for a canonical default re-export from @meshery/schemas.
src/schemas/helpAndSupportModal/uiSchema.tsx Swaps local UI schema literal for a canonical default re-export from @meshery/schemas.
package.json Pins @meshery/schemas devDependency to 1.2.11.
package-lock.json Updates lockfile to reflect @meshery/schemas@1.2.11 and resulting dependency graph changes.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the @meshery/schemas dependency to version 1.2.11 and refactors the help and support modal by replacing local schema and UI schema definitions with canonical re-exports from the updated package. Additionally, it includes several dependency adjustments in package-lock.json, such as removing development flags for MUI and React-related packages and updating others to devOptional. I have no feedback to provide as there were no review comments.

@mascot-five mascot-five merged commit 0266326 into master May 6, 2026
9 checks passed
@mascot-five mascot-five deleted the feat/helpandsupport-schema-from-meshery-schemas branch May 6, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants