feat(schemas): re-export helpAndSupportModal schemas from @meshery/schemas (closes #866)#1494
Conversation
…loses #866) Migrates helpAndSupportModalSchema / helpAndSupportModalUiSchema from hand-authored inline definitions to canonical re-exports from @meshery/schemas@1.2.11 (SupportRequestRjsfSchemaV1Beta1 / SupportRequestRjsfUiSchemaV1Beta1). This completes the full migration of all sistent RJSF form schemas to @meshery/schemas as the canonical source per meshery/schemas#866. Also fixes a latent bug: the prior default 'Technical' was not a member of enum ['Support','Community','Account','Commercial']; the canonical schema omits the invalid default. Signed-off-by: Lee Calcote <leecalcote@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR completes the migration of the helpAndSupportModal RJSF assets in Sistent to use the canonical schema/UI schema exports from @meshery/schemas, eliminating drift (including the previously invalid scope default) while keeping Sistent’s public export surface unchanged.
Changes:
- Replace hand-authored
helpAndSupportModalschema + UI schema with canonical re-exports (SupportRequestRjsfSchemaV1Beta1/SupportRequestRjsfUiSchemaV1Beta1) from@meshery/schemas. - Bump
@meshery/schemasfrom1.2.9to1.2.11. - Regenerate
package-lock.jsonfor the dependency bump.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/schemas/helpAndSupportModal/schema.tsx | Swaps local object literal for a canonical default re-export from @meshery/schemas. |
| src/schemas/helpAndSupportModal/uiSchema.tsx | Swaps local UI schema literal for a canonical default re-export from @meshery/schemas. |
| package.json | Pins @meshery/schemas devDependency to 1.2.11. |
| package-lock.json | Updates lockfile to reflect @meshery/schemas@1.2.11 and resulting dependency graph changes. |
There was a problem hiding this comment.
Code Review
This pull request updates the @meshery/schemas dependency to version 1.2.11 and refactors the help and support modal by replacing local schema and UI schema definitions with canonical re-exports from the updated package. Additionally, it includes several dependency adjustments in package-lock.json, such as removing development flags for MUI and React-related packages and updating others to devOptional. I have no feedback to provide as there were no review comments.
Summary
helpAndSupportModalSchemaandhelpAndSupportModalUiSchemawith canonical re-exports from@meshery/schemas@1.2.11(SupportRequestRjsfSchemaV1Beta1/SupportRequestRjsfUiSchemaV1Beta1).devDependencies["@meshery/schemas"]from1.2.9to1.2.11(pinned exact, matching the pattern from commitb8c7a204).package-lock.jsonto reflect the version bump.@meshery/schemasas the canonical source (Move hand-authored RJSF form schemas from layer5io/sistent to canonical @meshery/schemas meshery/schemas#866).Bug fixed
The hand-authored schema had
default: 'Technical'on thescopefield, but'Technical'is not a member of the declaredenum: ['Support', 'Community', 'Account', 'Commercial']. The canonical schema from@meshery/schemasomits this invalid default, resolving a latent RJSF validation inconsistency.Related
Test plan
npm installcompletes cleanly (lockfile updated)src/schemas/index.tsxcontinues to exporthelpAndSupportModalSchemaandhelpAndSupportModalUiSchemaas default re-exports (no consumer-side changes required)subject,message,scope(radio widget)