Add SQLite extension entrypoint config to sqlx.toml, update SQLite extension example#4107
Open
supleed2 wants to merge 2 commits intolaunchbadge:mainfrom
Open
Add SQLite extension entrypoint config to sqlx.toml, update SQLite extension example#4107supleed2 wants to merge 2 commits intolaunchbadge:mainfrom
sqlx.toml, update SQLite extension example#4107supleed2 wants to merge 2 commits intolaunchbadge:mainfrom
Conversation
Author
|
@abonander Can I ask for a review whenever you have time? I think this is ready and it rounds out the SQLite extension support already in the library |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does your PR solve an issue?
Closes #4093
Is this a breaking change?
No, the change is backwards compatible with the existing
Vec<String>format.Also, I did not find any tests for parsing thesqlx.toml, please let me know if there are and I just missed them.Same with if you think there needs to be extra documentation / explanations anywhere.
Edit: Failing tests pointed me in the right direction 👌