Conversation
Signed-off-by: 1fanwang <1fannnw@gmail.com>
Signed-off-by: 1fanwang <1fannnw@gmail.com>
Signed-off-by: 1fanwang <1fannnw@gmail.com>
Signed-off-by: 1fanwang <1fannnw@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
An observed context-manager generator replaces the application's error with
AttributeErrorand leaves its file open. This preserves the generator protocol under the tracing context, so exception handling and cleanup still run.Interrupt and process-exit exceptions also finish their observations and reach the caller unchanged.
Type of change
Verification
Testing Done
The reproducer is in the regression tests in this diff. It uses the real Langfuse client, an in-memory span exporter and real temporary files. It does not mock the tracing runtime or call a server or model.
The same tests ran against the fetched main commit with only the test file copied over, then against this branch.
Reproduction commands
Before and after, prior to forced cleanup:
Checklist
code_review.md..env.templateif needed.