feat(api): update API spec from langfuse/langfuse be747a7 - #1889
langfuse-bot wants to merge 1 commit into
Conversation
|
@claude review |
There was a problem hiding this comment.
Claude Code Review
No review was started: this request came from a bot account. Manual reviews can only be requested by someone with write access to this repository. Ask a maintainer to comment @claude review, or have your automation post the comment from a user account with write access.
Tip: disable this comment in your organization's Code Review settings.
| @@ -147,7 +134,6 @@ class IngestionEvent_ObservationUpdate(UniversalBaseModel): | |||
| IngestionEvent_GenerationCreate, | |||
There was a problem hiding this comment.
Code that imports the previously public IngestionEvent_SdkLog, SdkLogBody, or SdkLogEvent symbols will now fail at import time. Removing sdk-log from the discriminated union also prevents existing type="sdk-log" payloads from being validated. Preserve compatible models and exports for the current major version, or make this an explicitly breaking release. The related exports are also removed from langfuse/api/__init__.py, langfuse/api/ingestion/__init__.py, and langfuse/api/ingestion/types/__init__.py.
Prompt To Fix With AI
This is a comment left during a code review.
Path: langfuse/api/ingestion/types/ingestion_event.py
Line: 134
Comment:
**SDK-log API removed**
Code that imports the previously public `IngestionEvent_SdkLog`, `SdkLogBody`, or `SdkLogEvent` symbols will now fail at import time. Removing `sdk-log` from the discriminated union also prevents existing `type="sdk-log"` payloads from being validated. Preserve compatible models and exports for the current major version, or make this an explicitly breaking release. The related exports are also removed from `langfuse/api/__init__.py`, `langfuse/api/ingestion/__init__.py`, and `langfuse/api/ingestion/types/__init__.py`.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
LGTM, straightforward auto-generated API client regeneration.
What was reviewed: confirmed all 35 changed files are under langfuse/api/ and marked auto-generated; spot-checked the SdkLog type removal in ingestion_event.py and confirmed via repo-wide search that no other code references SdkLogBody/sdk-log, so the removal is safe; the remaining changes (new environment fields, new filter operators, new start_time param, docstring updates) are additive and match typical Fern-generated diffs from a backend spec bump.
Extended reasoning...
Overview
This PR is entirely confined to langfuse/api/, the Fern-generated API client. It reflects a backend OpenAPI/Fern spec update: removal of the deprecated sdk-log ingestion event type and its supporting SdkLogBody/SdkLogEvent classes, addition of new environment fields to several ingestion event/body types, a new optional start_time performance-hint parameter on the legacy get-observation endpoint, new "is set"/"is not set" filter operators added across several resource clients (scores, observations, trace, comments, metrics, opentelemetry, legacy observations_v1), a reordered/extended enum in evaluation_rule_filter.py, and minor docstring/parameter additions in the experiments and comments clients.
Security risks
None identified. There is no new authentication, authorization, crypto, or injection-relevant logic — these are typed request/response models, docstrings, and enum/literal additions generated from an API spec. The new filter operators and fields are passed through as plain data to the already-existing HTTP client machinery.
Level of scrutiny
Low-to-moderate is appropriate: the diff spans many files but each file's change is small and mechanical, matching the pattern of a routine Fern-generated client regen (this repo's langfuse/api package is explicitly auto-generated, per the header comment # This file was auto-generated present in all touched files). I verified the one behaviorally meaningful change (removing the SdkLog ingestion event) doesn't break any other part of the codebase by grepping the whole repo for lingering references — none were found, confirming clean removal.
Other factors
No CLAUDE.md conventions apply. The bug-hunting system reported no findings, and the PR conversation timeline shows no outstanding third-party objections. Given the generated, mechanical nature of the changes and the verification performed, this is safe to approve without requiring further human review.
The PR should not merge unchanged because it removes previously public SDK-log types without a compatibility path or an explicitly breaking release.
Summary
This PR regenerates the API client from an updated Langfuse specification.
stringObjectfilter operators and real-time API behavior.Reviews (1) · Last reviewed commit: "feat(api): update API spec from langfuse..."