Skip to content

fix: use ${PLUGIN_ROOT} so the Stop hook runs on Windows #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hassiebp merged 1 commit into from
Aug 31, 2026
Merged

fix: use ${PLUGIN_ROOT} so the Stop hook runs on Windows #64

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/tracing/hooks/hooks.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"hooks": [
{
"type": "command",
"command": "node \"${CODEX_HOME:-$HOME/.codex}/plugins/cache/codex-observability-plugin/tracing/0.1.0/dist/index.mjs\"",
"command": "node \"${PLUGIN_ROOT}/dist/index.mjs\"",
"timeout": 30,
"statusMessage": "Uploading Codex trace to Langfuse"
}
Expand Down
27 changes: 5 additions & 22 deletions plugins/tracing/test/hook-command.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,7 @@ import { afterEach, describe, expect, it } from "vitest";

const repoRoot = path.resolve(path.dirname(fileURLToPath(import.meta.url)), "../../..");
const hookConfigFile = path.join(repoRoot, "plugins/tracing/hooks/hooks.json");
const bundleFile = path.join(repoRoot, "plugins/tracing/dist/index.mjs");
const pluginManifestFile = path.join(repoRoot, "plugins/tracing/.codex-plugin/plugin.json");
const pluginRootDir = path.join(repoRoot, "plugins/tracing");

const tmpDirs: string[] = [];

Expand All @@ -26,20 +25,6 @@ function readHookCommand(): string {
return config.hooks.Stop[0].hooks[0].command;
}

function readPluginVersion(): string {
const manifest = JSON.parse(fs.readFileSync(pluginManifestFile, "utf-8")) as { version: string };
return manifest.version;
}

function stageInstalledPlugin(codexHome: string): void {
const installedBundle = path.join(
codexHome,
"plugins/cache/codex-observability-plugin/tracing/0.1.0/dist/index.mjs",
);
fs.mkdirSync(path.dirname(installedBundle), { recursive: true });
fs.copyFileSync(bundleFile, installedBundle);
}

function runShellCommand(
command: string,
options: { cwd: string; env: NodeJS.ProcessEnv; input: string },
Expand Down Expand Up @@ -81,15 +66,15 @@ afterEach(() => {
});

describe("bundled Stop hook command", () => {
it("runs from an arbitrary session cwd via CODEX_HOME instead of a relative repo path", async () => {
it("runs from an arbitrary session cwd via PLUGIN_ROOT instead of a relative repo path", async () => {
const codexHome = makeTempDir("lf-codex-home-");
const sessionCwd = makeTempDir("lf-codex-cwd-");
stageInstalledPlugin(codexHome);

const { code, stderr, stdout } = await runShellCommand(readHookCommand(), {
cwd: sessionCwd,
env: {
...process.env,
PLUGIN_ROOT: pluginRootDir,
CODEX_HOME: codexHome,
HOME: codexHome,
},
Expand All @@ -108,9 +93,7 @@ describe("bundled Stop hook command", () => {
expect(readHookCommand()).not.toContain("./plugins/tracing/dist/index.mjs");
});

it("points at the installed cache path for this plugin version", () => {
expect(readHookCommand()).toContain(
`/plugins/cache/codex-observability-plugin/tracing/${readPluginVersion()}/dist/index.mjs`,
);
it("uses no shell syntax beyond the placeholder Codex substitutes itself", () => {
expect(readHookCommand().replaceAll("${PLUGIN_ROOT}", "")).not.toContain("$");
});
});