Skip to content

fix(network): enforce owned app networks - #89

Merged
vishr merged 1 commit into
mainfrom
fix/network-ownership
Aug 21, 2026
Merged

fix(network): enforce owned app networks#89
vishr merged 1 commit into
mainfrom
fix/network-ownership

Conversation

@vishr

@vishr vishr commented Aug 21, 2026

Copy link
Copy Markdown
Member

Summary

  • make <app>_default and ob_<app> explicit external networks owned by Onebox
  • reject foreign or ambiguous derived-name collisions without adopting them
  • preserve legacy Compose/service networks only with independent ownership evidence
  • remove owned external networks safely during full destroy while retaining recovery state on attached endpoints
  • reserve ingress names that collide with Onebox-managed networks
  • document the ownership and destroy lifecycle

Refs #35

Validation

  • just check
  • just lint (0 issues)
  • go test -race ./... (1,466 tests)
  • just e2e against the OrbStack Docker daemon (full suite, 288s)
  • targeted real-Docker network ownership lifecycle after final changes
  • Ubuntu 24.04 OrbStack VM A/B: merged main silently accepted a foreign <app>_default; this branch rejects it, creates labelled app/service networks, and preserves an attached unmanaged endpoint across release teardown
  • independent codex review --uncommitted: no actionable correctness issues

Create app-scoped networks under explicit ownership, reject foreign collisions, and keep release teardown from removing shared endpoints. Full destroy now removes owned networks safely before releasing state.

Refs #35
@vishr
vishr merged commit 6638ad8 into main Aug 21, 2026
5 checks passed
@vishr
vishr deleted the fix/network-ownership branch August 21, 2026 23:13
vishr added a commit that referenced this pull request Aug 24, 2026
Create app-scoped networks under explicit ownership, reject foreign collisions, and keep release teardown from removing shared endpoints. Full destroy now removes owned networks safely before releasing state.

Refs #35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant