Add a proposal to deprecate io.kroxylicious.proxy.config.tls#94
Open
tombentley wants to merge 1 commit intokroxylicious:mainfrom
Open
Add a proposal to deprecate io.kroxylicious.proxy.config.tls#94tombentley wants to merge 1 commit intokroxylicious:mainfrom
tombentley wants to merge 1 commit intokroxylicious:mainfrom
Conversation
Assisted-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Tom Bentley <tbentley@redhat.com>
robobario
approved these changes
Apr 13, 2026
|
|
||
| ## Affected/not affected projects | ||
|
|
||
| This affects the kroxylicious repository only. |
Member
There was a problem hiding this comment.
maybe worth a specific mention of the operator as it should be migrated to use the new types for Config generation ASAP
| @@ -0,0 +1,114 @@ | |||
| # Cleaning up TLS configurations | |||
|
|
|||
| We propose to deprecate `git io.kroxylicious.proxy.config.tls` in the `kroxylicious-api` module. | |||
Member
There was a problem hiding this comment.
Suggested change
| We propose to deprecate `git io.kroxylicious.proxy.config.tls` in the `kroxylicious-api` module. | |
| We propose to deprecate `io.kroxylicious.proxy.config.tls` in the `kroxylicious-api` module. |
k-wall
approved these changes
Apr 16, 2026
Member
Author
|
This has sufficient approvals to be considered accepted. However, I've not merged it yet while the conversation in #96 is on-going. |
k-wall
added a commit
to k-wall/design
that referenced
this pull request
Apr 28, 2026
This change simplifies the proposal numbering system by using PR numbers as proposal identifiers, eliminating number collisions and removing the need for a separate allocation process. Changes: - Simplified proposals/README.md to focus on author workflow - Removed index tables (directory listing serves as the index) - Streamlined instructions for creating and renaming proposals - Updated proposal template with workflow instructions - Require PR number in title format: # <PR#> - <Title> - Moved workflow instructions into comment block - Added GitHub workflow to automatically check proposal numbering - Validates both filename and title format - Updates PR description when proposal files don't match PR number - Provides exact commands to fix naming issues - Removes warning once corrected - Handles both added and renamed files - Runs on all PRs (ready for mandatory status check) - Added notification script for existing open PRs - After merge, run notify-open-prs.sh to ask authors to rebase - Workflow will automatically guide them through renaming - Updated with all current open proposal PRs (kroxylicious#70, kroxylicious#82, kroxylicious#83, kroxylicious#85, kroxylicious#88, kroxylicious#93, kroxylicious#94, kroxylicious#96, kroxylicious#98, kroxylicious#99, kroxylicious#100, kroxylicious#101, kroxylicious#103) Proposals 001-019 retain their original numbers. Assisted-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Keith Wall <kwall@apache.org>
k-wall
added a commit
that referenced
this pull request
Apr 28, 2026
This change simplifies the proposal numbering system by using PR numbers as proposal identifiers, eliminating number collisions and removing the need for a separate allocation process. Changes: - Simplified proposals/README.md to focus on author workflow - Removed index tables (directory listing serves as the index) - Streamlined instructions for creating and renaming proposals - Updated proposal template with workflow instructions - Require PR number in title format: # <PR#> - <Title> - Moved workflow instructions into comment block - Added GitHub workflow to automatically check proposal numbering - Validates both filename and title format - Updates PR description when proposal files don't match PR number - Provides exact commands to fix naming issues - Removes warning once corrected - Handles both added and renamed files - Runs on all PRs (ready for mandatory status check) - Added notification script for existing open PRs - After merge, run notify-open-prs.sh to ask authors to rebase - Workflow will automatically guide them through renaming - Updated with all current open proposal PRs (#70, #82, #83, #85, #88, #93, #94, #96, #98, #99, #100, #101, #103) Proposals 001-019 retain their original numbers. Assisted-By: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Keith Wall <kwall@apache.org>
Member
|
Hi! We've updated the proposal numbering system to use PR numbers as proposal identifiers. Action required: Please rebase your PR on Once you rebase, you'll need to rename your proposal file and update the title: git mv proposals/nnn-tls-configuration.md proposals/094-tls-configuration.md
# Update title: remove any old number prefix and add PR number
sed -i.bak '0,/^# /{s/^# \([0-9]\{3\}\|xxx\|nnn\|000\) - /# 94 - /; t; s/^# /# 94 - /}' proposals/094-tls-configuration.md && rm proposals/094-tls-configuration.md.bak
git add proposals/094-tls-configuration.md
git commit -m "Rename proposal to use PR number"
git pushThe GitHub workflow will automatically check your proposal file naming after you push and update this PR description if any corrections are still needed. See proposals/README.md for the updated workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposal is intended to formally describe and solve kroxylicious/kroxylicious#3456