Skip to content

Fix GitHub Actions conditional expression in go.yml#4446

Open
aravindtga wants to merge 1 commit intokptdev:mainfrom
Nordix:ci-fix-podman-conditional-exp
Open

Fix GitHub Actions conditional expression in go.yml#4446
aravindtga wants to merge 1 commit intokptdev:mainfrom
Nordix:ci-fix-podman-conditional-exp

Conversation

@aravindtga
Copy link
Copy Markdown
Contributor

The if condition on the "check podman" step had the comparison operator outside the ${{ }} delimiters:

# Before
if: ${{ matrix.runtime }} == 'podman'
# After
if: ${{ matrix.runtime == 'podman' }}

The original expression evaluated to a non-empty string (e.g. "docker == 'podman'"), which is always true, causing the step to run for both docker and podman matrix entries.
image

This fix ensures it only runs for the podman runtime.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 24, 2026

Deploy Preview for kptdocs ready!

Name Link
🔨 Latest commit f3f9d29
🔍 Latest deploy log https://app.netlify.com/projects/kptdocs/deploys/69c6d6c706b36f00086f9a7d
😎 Deploy Preview https://deploy-preview-4446--kptdocs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@aravindtga aravindtga marked this pull request as ready for review March 24, 2026 15:49
Copilot AI review requested due to automatic review settings March 24, 2026 15:49
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. area/devops labels Mar 24, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a GitHub Actions if: expression so the “check podman” step only runs for the podman matrix entry (instead of always evaluating truthy).

Changes:

  • Correct the GitHub Actions conditional expression syntax for the “check podman” step.
  • Update the workflow file header copyright year text.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@@ -1,4 +1,4 @@
# Copyright 2019 The kpt Authors
# Copyright 2019, 2026 The kpt Authors
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Copyright 2019, 2026 The kpt Authors
# Copyright 2019-2026 The kpt Authors

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use this kind of notion where we update the copyright notices. It indicates continuous development.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
@aravindtga aravindtga force-pushed the ci-fix-podman-conditional-exp branch from b1716e3 to f3f9d29 Compare March 27, 2026 19:13
Copilot AI review requested due to automatic review settings March 27, 2026 19:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/devops size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants