Fix GitHub Actions conditional expression in go.yml#4446
Fix GitHub Actions conditional expression in go.yml#4446aravindtga wants to merge 1 commit intokptdev:mainfrom
Conversation
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Fixes a GitHub Actions if: expression so the “check podman” step only runs for the podman matrix entry (instead of always evaluating truthy).
Changes:
- Correct the GitHub Actions conditional expression syntax for the “check podman” step.
- Update the workflow file header copyright year text.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c0a736e to
b1716e3
Compare
.github/workflows/go.yml
Outdated
| @@ -1,4 +1,4 @@ | |||
| # Copyright 2019 The kpt Authors | |||
| # Copyright 2019, 2026 The kpt Authors | |||
There was a problem hiding this comment.
| # Copyright 2019, 2026 The kpt Authors | |
| # Copyright 2019-2026 The kpt Authors |
There was a problem hiding this comment.
I would use this kind of notion where we update the copyright notices. It indicates continuous development.
Signed-off-by: Aravindhan Ayyanathan <aravindhan.a@est.tech>
b1716e3 to
f3f9d29
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The if condition on the "check podman" step had the comparison operator outside the ${{ }} delimiters:
The original expression evaluated to a non-empty string (e.g. "docker == 'podman'"), which is always true, causing the step to run for both docker and podman matrix entries.

This fix ensures it only runs for the podman runtime.