Draft
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refreshing some of the implementation of the Kokkos Kernels backend so that we can re-compile and run the tests.
Mostly changing namespaces and a few signatures that changed, especially that of
std::extents.The mdspan_to_view test compiles and fails at runtime because the checks are not correct.
utest_dot_kokkos_exetest compiles and passes.Note: something is not working with the complex test and I'm choosing to ignore it for the time being but if you have ideas for it let me know...
Let me know if you want the general approach I took to be changed or if modifying the other tests along the same lines would be reasonable?