Skip to content

DEVOPS-3809: Incremental version bumps for AP 5.12.0 #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knime-ghub-bot merged 1 commit into from
Mar 5, 2026
Merged

DEVOPS-3809: Incremental version bumps for AP 5.12.0 #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions org.knime.features.python3.nodes/feature.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<feature
id="org.knime.features.python3.nodes"
label="KNIME Python Extension Development (Labs)"
version="5.11.0.qualifier"
version="5.12.0.qualifier"
provider-name="KNIME AG, Zurich, Switzerland">

<description>
Expand Down Expand Up @@ -728,7 +728,7 @@ propagated with or for interoperation with KNIME.
</license>

<requires>
<import feature="org.knime.features.core.columnar" version="5.11.0" match="greaterOrEqual"/>
<import feature="org.knime.features.core.columnar" version="5.12.0" match="greaterOrEqual"/>
</requires>

<plugin
Expand Down
2 changes: 1 addition & 1 deletion org.knime.features.python3.scripting/feature.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,7 +730,7 @@ propagated with or for interoperation with KNIME.
<requires>
<import feature="org.knime.features.python2" version="5.12.0" match="greaterOrEqual"/>
<import feature="org.knime.features.conda" version="5.12.0" match="greaterOrEqual"/>
<import feature="org.knime.features.core.columnar" version="5.11.0" match="greaterOrEqual"/>
<import feature="org.knime.features.core.columnar" version="5.12.0" match="greaterOrEqual"/>
<import feature="org.knime.features.pythonscripting" version="5.11.0" match="greaterOrEqual"/>
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the AP 5.12.0 version-bump context, the required features were mostly bumped to 5.12.0, but org.knime.features.pythonscripting is still listed with a 5.11.0 lower bound. If the intention is to require a full 5.12.0 baseline, this import should likely be updated to 5.12.0 for consistency.

Suggested change
<import feature="org.knime.features.pythonscripting" version="5.11.0" match="greaterOrEqual"/>
<import feature="org.knime.features.pythonscripting" version="5.12.0" match="greaterOrEqual"/>

Copilot uses AI. Check for mistakes.
</requires>

Expand Down
6 changes: 3 additions & 3 deletions org.knime.python3.arrow/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,22 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: KNIME Python - Data Transfer using Apache Arrow
Bundle-SymbolicName: org.knime.python3.arrow;singleton:=true
Bundle-Version: 5.11.0.qualifier
Bundle-Version: 5.12.0.qualifier
Bundle-ClassPath: knime-python3-arrow.jar
Bundle-Vendor: KNIME AG, Zurich, Switzerland
Bundle-RequiredExecutionEnvironment: JavaSE-17
Bundle-ActivationPolicy: lazy
Require-Bundle: org.knime.python3;bundle-version="[5.11.0,6.0.0)",
org.knime.core.table;bundle-version="[5.9.0,6.0.0)",
org.knime.core.columnar;bundle-version="[5.11.0,6.0.0)",
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bundle now requires org.knime.core >= 5.12.0 and org.knime.core.columnar.arrow >= 5.12.0, but still allows org.knime.core.columnar >= 5.11.0. Consider bumping org.knime.core.columnar’s lower bound to 5.12.0 as well to keep the dependency baseline consistent for AP 5.12.0.

Suggested change
org.knime.core.columnar;bundle-version="[5.11.0,6.0.0)",
org.knime.core.columnar;bundle-version="[5.12.0,6.0.0)",

Copilot uses AI. Check for mistakes.
org.knime.core.columnar.arrow;bundle-version="[5.11.0,6.0.0)",
org.knime.core.columnar.arrow;bundle-version="[5.12.0,6.0.0)",
slf4j.api;bundle-version="[2.0.12,3.0.0)",
org.apache.commons.commons-io;bundle-version="[2.15.1,3.0.0)",
org.apache.arrow.memory-core;bundle-version="[18.1.0,19.0.0)",
org.apache.arrow.format;bundle-version="[18.1.0,19.0.0)",
org.apache.arrow.vector;bundle-version="[18.1.0,19.0.0)",
org.eclipse.core.runtime;bundle-version="[3.20.100,4.0.0)",
org.knime.core;bundle-version="[5.11.0,6.0.0)",
org.knime.core;bundle-version="[5.12.0,6.0.0)",
org.knime.core.data.columnar;bundle-version="[5.9.0,6.0.0)",
org.knime.ext.py4j;bundle-version="[0.10.9.2,1.0.0)",
com.google.guava;bundle-version="[19.0.0,20.0.0)"
Expand Down
14 changes: 7 additions & 7 deletions org.knime.python3.scripting.nodes/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: KNIME Python 3 - Scripting Nodes
Bundle-SymbolicName: org.knime.python3.scripting.nodes;singleton:=true
Bundle-Version: 5.11.0.qualifier
Bundle-Version: 5.12.0.qualifier
Bundle-ClassPath: knime-python3-scripting-nodes.jar
Bundle-Vendor: KNIME AG, Zurich, Switzerland
Bundle-RequiredExecutionEnvironment: JavaSE-17
Bundle-ActivationPolicy: lazy
Require-Bundle: org.knime.core;bundle-version="[5.11.0,6.0.0)",
org.knime.base;bundle-version="[5.11.0,6.0.0)",
org.knime.core.columnar.arrow;bundle-version="[5.11.0,6.0.0)",
Require-Bundle: org.knime.core;bundle-version="[5.12.0,6.0.0)",
org.knime.base;bundle-version="[5.12.0,6.0.0)",
org.knime.core.columnar.arrow;bundle-version="[5.12.0,6.0.0)",
org.knime.core.columnar;bundle-version="[5.11.0,6.0.0)",
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The required bundle version bounds are inconsistent: this bundle now requires org.knime.core and org.knime.core.columnar.arrow >= 5.12.0, but still allows org.knime.core.columnar >= 5.11.0. For an AP 5.12.0 baseline bump, consider raising org.knime.core.columnar’s lower bound to 5.12.0 as well to avoid resolving against an older columnar bundle.

Suggested change
org.knime.core.columnar;bundle-version="[5.11.0,6.0.0)",
org.knime.core.columnar;bundle-version="[5.12.0,6.0.0)",

Copilot uses AI. Check for mistakes.
org.knime.core.table;bundle-version="[5.9.0,6.0.0)",
org.knime.python2;bundle-version="[5.9.0,6.0.0)",
Expand All @@ -18,13 +18,13 @@ Require-Bundle: org.knime.core;bundle-version="[5.11.0,6.0.0)",
org.knime.python3.types;bundle-version="[5.9.0,6.0.0)",
org.knime.python3;bundle-version="[5.11.0,6.0.0)",
org.knime.python3.views;bundle-version="[5.9.0,6.0.0)",
org.knime.python3.arrow;bundle-version="[5.11.0,6.0.0)",
org.knime.python3.arrow;bundle-version="[5.12.0,6.0.0)",
org.knime.ext.py4j;bundle-version="[0.10.9.2,1.0.0)",
org.eclipse.ui;bundle-version="3.119.0",
org.knime.conda;bundle-version="[5.11.0,6.0.0)",
org.knime.conda.envbundling;bundle-version="[5.11.0,6.0.0)",
Comment on lines 24 to 25
Copy link

Copilot AI Mar 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

org.knime.conda and org.knime.conda.envbundling are still pinned to a >= 5.11.0 lower bound while other AP dependencies in this manifest were bumped to >= 5.12.0. If the goal is to enforce an AP 5.12.0 baseline, these should likely be bumped to >= 5.12.0 for consistency (and to match the feature requirement on org.knime.features.conda 5.12.0).

Suggested change
org.knime.conda;bundle-version="[5.11.0,6.0.0)",
org.knime.conda.envbundling;bundle-version="[5.11.0,6.0.0)",
org.knime.conda;bundle-version="[5.12.0,6.0.0)",
org.knime.conda.envbundling;bundle-version="[5.12.0,6.0.0)",

Copilot uses AI. Check for mistakes.
org.knime.pixi.port;bundle-version="[5.11.0,6.0.0)",
org.knime.core.ui;bundle-version="[5.11.0,6.0.0)",
org.knime.pixi.port;bundle-version="[5.12.0,6.0.0)",
org.knime.core.ui;bundle-version="[5.12.0,6.0.0)",
org.knime.workbench.editor;bundle-version="[5.10.0,6.0.0)",
org.apache.batik.util;bundle-version="[1.16.0,2.0.0)",
org.apache.batik.dom;bundle-version="[1.16.0,2.0.0)",
Expand Down
Loading