-
Notifications
You must be signed in to change notification settings - Fork 3
Todo/ap 25545 update deps #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates multiple dependencies in the project, particularly transitioning from older LangChain packages to newer versions and package structures.
Changes:
- Migration from
langchaintolangchain-classicfor legacy agent and chain components - Switch from
langchain-google-vertexaitolangchain-google-genaifor Google model integrations - Update to Python 3.13 and comprehensive dependency version updates in
pixi.toml
Reviewed changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tools/vectorstore.py | Updates imports to use langchain_classic for retrieval chains |
| src/models/google/_port_types.py | Switches from Vertex AI to Google Generative AI SDK with updated parameter names |
| src/models/_adapter.py | Changes LLM invocation method from direct call to .invoke() |
| src/indexes/chroma.py | Simplifies Chroma vectorstore handling logic |
| src/eval/giskard/giskard_patch.py | Adds monkey-patch for scipy compatibility with Giskard |
| src/eval/giskard/init.py | Imports the new giskard_patch module |
| src/agents/openai.py | Updates import to use langchain_classic |
| src/agents/base_deprecated.py | Moves imports to local scope and adds ToolNode usage |
| src/agents/base.py | Updates agent execution to use langchain_classic.agents.AgentExecutor and adds ToolNode |
| src/agents/_tool.py | Switches from langchain.tools to langchain_core.tools |
| pixi.toml | Major dependency reorganization with Python 3.13 upgrade and version updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| validate_ai_message, | ||
| LANGGRAPH_RECURSION_MESSAGE, |
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent indentation in the import statement. The closing parenthesis should align with the opening line or the imported items should be consistently indented.
| validate_ai_message, | |
| LANGGRAPH_RECURSION_MESSAGE, | |
| validate_ai_message, | |
| LANGGRAPH_RECURSION_MESSAGE, |
pixi.toml
Outdated
|
|
||
| [pypi-options] | ||
| no-build = true | ||
| # no-build = true |
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented-out configuration should either be removed or include a comment explaining why it's disabled and under what circumstances it should be re-enabled.
| # no-build = true | |
| # no-build = true # Disabled to allow building packages from source during local development; re-enable in CI for reproducible binary-only builds. |
pixi.toml
Outdated
| python = "3.13.*" # Runtime: Python 3.13 | ||
| knime-extension = "5.8.*" # Framework: KNIME Python integration | ||
| knime-python-base = "*" # Framework: KNIME base libraries | ||
| # knime-python-versions = "5.8.*" |
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commented-out dependency should either be removed or include a comment explaining why it's disabled and when it should be re-enabled.
| # knime-python-versions = "5.8.*" | |
| # knime-python-versions = "5.8.*" # Disabled: only needed for multi-runtime KNIME setups; re-enable if/when multiple Python versions must be supported |
2b561f7 to
9520191
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| max_retries=2, # default is 6, instead we just try twice before failing | ||
| base_url=self.custom_base_api_url or self.base_api_url, | ||
| credentials=google_credentials, | ||
| task_type="RETRIEVAL_QUERY", # for backwards compatibility with old VertexAIEmbeddings |
Copilot
AI
Jan 26, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space after '#' in comment.
| task_type="RETRIEVAL_QUERY", # for backwards compatibility with old VertexAIEmbeddings | |
| task_type="RETRIEVAL_QUERY", # for backwards compatibility with old VertexAIEmbeddings |
4cf2a2d to
6a4a163
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Which now provides a unified API for Google AI Studio and Vertex AI
For backwards compatibility
Because chroma no longer provides the information where the vectorstore is persisted.
Tested locally on Windows.
AP-25545 (Update to latest langchain 1.x version)
6a4a163 to
e216fa0
Compare
e216fa0 to
8f521fb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AP-25545 (Update to latest langchain 1.x version)
8f521fb to
11b6898
Compare
AP-25545 (Update to latest langchain 1.x version)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 11 out of 12 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| max_retries=2, # default is 6, instead we just try twice before failing | ||
| base_url=self.custom_base_api_url or self.base_api_url, | ||
| credentials=google_credentials, | ||
| task_type="RETRIEVAL_QUERY", # for backwards compatibility with old VertexAIEmbeddings |
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing space after '#' in comment. Should be '# for backwards compatibility'.
| # AP-25545: Monkey-patch scipy.stats.stats to fix Giskard import error with newer scipy versions | ||
| # The error is: ImportError: cannot import name 'Ks_2sampResult' from 'scipy.stats.stats' |
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding documentation about when this patch can be removed (e.g., 'Remove when Giskard updates to support scipy >= X.Y.Z' or a link to the upstream issue).
| # AP-25545: Monkey-patch scipy.stats.stats to fix Giskard import error with newer scipy versions | |
| # The error is: ImportError: cannot import name 'Ks_2sampResult' from 'scipy.stats.stats' | |
| # AP-25545: Monkey-patch scipy.stats.stats to fix Giskard import error with newer scipy versions. | |
| # The error is: ImportError: cannot import name 'Ks_2sampResult' from 'scipy.stats.stats'. | |
| # TODO: Remove this patch when Giskard no longer imports Ks_2sampResult from scipy.stats.stats, | |
| # or when we depend on a Giskard version that supports newer SciPy versions without this workaround. |
|
|
||
| # --- Vector Stores & Indexes --- | ||
| faiss-cpu = "*" # Direct: used in indexes/faiss.py | ||
| langchain-chroma = "==1.1.0" # Direct: used in indexes/chroma.py installed via pypi because conda packages don't support python 3.13 |
Copilot
AI
Feb 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment runs over multiple concepts without proper separation. Consider splitting into: 'Direct: used in indexes/chroma.py. Installed via PyPI because conda packages don't support Python 3.13'.
| langchain-chroma = "==1.1.0" # Direct: used in indexes/chroma.py installed via pypi because conda packages don't support python 3.13 | |
| langchain-chroma = "==1.1.0" # Direct: used in indexes/chroma.py. Installed via PyPI because conda packages don't support Python 3.13 |
No description provided.