Fix search bar expansion to overlay navigation items#6532
Fix search bar expansion to overlay navigation items#6532codeEvolveZenith345 wants to merge 1 commit intoknative:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: codeEvolveZenith345 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for knative ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/retest |
|
@codeEvolveZenith345: Cannot trigger testing until a trusted user reviews the PR and leaves an DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8924c93 to
ef01884
Compare
|
I have kept the expansion limited to the right side though, as the search bars normally remain on the side of their initial placement, then to expand over the entire screen. |
ef01884 to
7d0b862
Compare
7d0b862 to
ca499cd
Compare
|
I don't like the jitter that happens when you open it. Also the navigation text disappears so it doesn't look polished |
|
Hi @dprotaso |
|
I request you to elaborate it thoroughly... |
|
take a look at https://squidfunk.github.io/mkdocs-material/tutorials/ When you click the search bar it's right side is fixed and it expands to the left. |
Signed-off-by: Aditya Tiwari <suntiwari3495@gmail.com>
ca499cd to
02dc30a
Compare
|
I'm not seeing much difference between the changes in this PR and what we already have on the knative.dev website |
|
Hi! @dprotaso |
Actually the |
Description:
Fixes #6332
Proposed Changes
Recording.2025-11-30.105520.mp4