Repository navigation
kbuild: request dtbs-legacy alongside dtbs in tuxmake builds - #3238
Merged
Merged
Conversation
tuxmake's dtbs target only runs when the top-level Makefile has a dtbs_install target, which kernels gained in v4.20. On older kernels it is skipped, the build still passes and no DTBs are produced, so boot jobs on device tree platforms have nothing to boot with. tuxmake handles those kernels with a separate dtbs-legacy target whose precondition is the inverse of dtbs, so at most one of the two runs. Request both whenever DTBs are built. Signed-off-by: Ben Copeland <ben.copeland@linaro.org>
bhcopeland
force-pushed
the
kbuild-tuxmake-dtbs-legacy
branch
from
October 6, 2026 09:52
6580ff4 to
e724eeb
Compare
roxell
approved these changes
Oct 6, 2026
nuclearcat
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tuxmake's dtbs target only runs when the top-level Makefile has a dtbs_install target, which kernels gained in v4.20. On older kernels it is skipped, the build still passes and no DTBs are produced, so boot jobs on device tree platforms have nothing to boot with.
tuxmake handles those kernels with a separate dtbs-legacy target whose precondition is the inverse of dtbs, so at most one of the two runs. Request both whenever DTBs are built.
Skip extra_targets entries that are already requested, so jobs that added dtbs-legacy themselves do not pass it twice.