Add document bookmarks#13
Draft
tnsardesai wants to merge 3 commits into
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- persist the view token a doc was bookmarked through and re-check access with it on /bookmarks, so a token-shared doc stays linkable (token re-appended) until the token is rotated or the doc is revoked - make the doc-page bookmark button a real toggle (add/remove) - add a per-row remove control on /bookmarks, working for revoked docs too - revoked bookmarks show "<doc id> — revoked" with no link, never the live title of a doc the viewer can no longer access - label token-only access "link" (was mislabeled "public") - extract pure row rendering to lib/docs/bookmarks-view.ts with unit tests Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add the /bookmarks web surface to the Viewing listing in skill-content.ts (the source for /llms.txt and SKILL.md), alongside its sibling /docs. Regenerated SKILL.md via gen:skill. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds document bookmarks. Every doc page gets a bookmark button that saves the doc to the signed-in user's bookmarks, and
/bookmarkslists them — split into "your documents" and "shared with you", mirroring the/docsdesign.Bookmarks re-resolve access on every load rather than trusting save-time access, so they honor the same authorization as the viewer:
revokedwith no link, showing only its doc id — never the live title of a doc the viewer can no longer see.Behavior
/bookmarksroute with OWNED and SHARED-WITH-YOU sections, man-page styled like/docs.removeon/bookmarks, keyed by doc id so revoked/deleted docs can still be dropped.owner/editor/commenter/viewer/public/link(token-only) /revoked.bookmarkstable migration; nav links added from/and/docs.lib/docs/bookmarks-view.ts(unit-tested).Tests
npm test(includeslib/docs/bookmarks-view.test.tscovering revoked / token-link / remove-form rendering)npm run build