Skip to content

Handle X11 errors during webview destruction on Linux to prevent crashes. #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kdroidFilter merged 2 commits into from
Mar 2, 2026
Merged

Handle X11 errors during webview destruction on Linux to prevent crashes. #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc8c98d
Handle X11 errors during webview destruction on Linux to prevent cras…
Mar 2, 2026
82a9c47
Merge branch 'kdroidFilter:main' into main
zaroxh Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions wrywebview/src/main/rust/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,6 +998,19 @@ pub fn close_dev_tools(id: u64) -> Result<(), WebViewError> {

fn destroy_webview_inner(id: u64) -> Result<(), WebViewError> {
wry_log!("[wrywebview] destroy_webview id={}", id);

#[cfg(target_os = "linux")]
{
gdk::error_trap_push();
let res = unregister(id);
while gtk::events_pending() {
gtk::main_iteration_do(false);
}
let _ = gdk::error_trap_pop();
res
}

#[cfg(not(target_os = "linux"))]
unregister(id)
}

Expand Down