Skip to content

Remove k8s/ directory pins with cert-manager changes upstreamed#75

Open
ddelnano wants to merge 1 commit into
mainfrom
ddelnano/remove-k8s-directory-pin
Open

Remove k8s/ directory pins with cert-manager changes upstreamed#75
ddelnano wants to merge 1 commit into
mainfrom
ddelnano/remove-k8s-directory-pin

Conversation

@ddelnano

Copy link
Copy Markdown

Summary: Remove k8s/ directory pins with cert-manager changes upstreamed

This removes the k8s/ directory pin that was protected the cert-manager changes upstreamed in pixie-io@77e8d9e and pixie-io@7622689.

Relevant Issues: N/A

Type of change: /kind cleanup

Test Plan: Will watch the next copybara sync to verify it merges properly

Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2a839208-443c-4df4-ac9c-a06a29ad8e19

📥 Commits

Reviewing files that changed from the base of the PR and between 53d09cc and 5af3d65.

📒 Files selected for processing (1)
  • tools/private/copybara/copy.bara.sky

📝 Walkthrough

Walkthrough

The Copybara ignored_dirs in copy.bara.sky is updated to replace the broad k8s/** ignore with explicit paths for fork-specific Kubernetes files: plugin/updater YAMLs, k8s/vizier/BUILD.bazel, and the exposed_services_traefik overlay subtree. Inline comments document the new upstream sync stance.

Changes

Copybara k8s ignore refinement

Layer / File(s) Summary
Targeted k8s ignore paths
tools/private/copybara/copy.bara.sky
Replaces the catch-all k8s/** entry in ignored_dirs with specific fork-divergent paths (plugin/updater YAMLs, k8s/vizier/BUILD.bazel, k8s/cloud/overlays/exposed_services_traefik/**) and adds comments noting the k8s cloud/vizier cert-manager area is no longer frozen upstream.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • k8sstormcenter/pixie#39: Also modifies ignored_dirs/fork_only_files in copy.bara.sky to adjust path-filtering rules for Copybara sync.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly reflects the main change: removing the k8s/ pin after cert-manager changes were upstreamed.
Description check ✅ Passed The description is directly related to the change and explains why the k8s/ pin can be removed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ddelnano/remove-k8s-directory-pin

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant