Skip to content

Handle github-activity>=1.1.4#637

Merged
krassowski merged 1 commit intojupyter-server:mainfrom
jtpio:fix-github-activity
Jan 1, 2026
Merged

Handle github-activity>=1.1.4#637
krassowski merged 1 commit intojupyter-server:mainfrom
jtpio:fix-github-activity

Conversation

@jtpio
Copy link
Copy Markdown
Member

@jtpio jtpio commented Dec 31, 2025

As noticed in executablebooks/github-activity#162 (comment), github-activity>=1.1.4 now throws when no results are returned.

This leads to the check_release job sometimes failing on CI, usually right after a release (since there is no new PR):

https://github.com/jtpio/jupyterlite-server-contents/actions/runs/20604073817/job/59175936047

ValueError: No activity found for <repo-name> between v0.1.1 and None.

We can handle this new behavior by being more defensive.

@jtpio jtpio added the bug Something isn't working label Dec 31, 2025
@jtpio jtpio marked this pull request as ready for review December 31, 2025 15:00
@jtpio
Copy link
Copy Markdown
Member Author

jtpio commented Dec 31, 2025

cc @AntoinePrv this should fix the issue you have been seeing in your extension after making a new release

Copy link
Copy Markdown
Collaborator

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@krassowski krassowski merged commit 472d8f7 into jupyter-server:main Jan 1, 2026
19 of 20 checks passed
@jtpio jtpio deleted the fix-github-activity branch May 4, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants