Skip to content

remove UPX compressions - #15

Open
bennyz wants to merge 1 commit into
jumpstarter-dev:mainfrom
bennyz:remove-upx
Open

remove UPX compressions#15
bennyz wants to merge 1 commit into
jumpstarter-dev:mainfrom
bennyz:remove-upx

Conversation

@bennyz

@bennyz bennyz commented Jul 27, 2026

Copy link
Copy Markdown
Member

it seems to be root cause of segfaults on aarch64

it seems to be root cause of segfaults on aarch64

Signed-off-by: Benny Zlotnik <bzlotnik@redhat.com>
@bennyz
bennyz requested a review from mangelajo July 27, 2026 08:41
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 18bfbe42-2150-4419-9c72-baa4374a53a4

📥 Commits

Reviewing files that changed from the base of the PR and between 31f3789 and c58b23c.

📒 Files selected for processing (4)
  • .github/workflows/ci.yml
  • .github/workflows/release.yml
  • Containerfile
  • Makefile

📝 Walkthrough

Walkthrough

UPX compression was removed from Makefile targets, the ARM64 container build, and CI/release artifact preparation. Workflows now copy uncompressed binaries, retain size reporting, and generate checksums for the resulting artifacts.

Changes

UPX compression removal

Layer / File(s) Summary
Remove compressed build targets
Makefile
Compressed build targets, the UPX rule, its phony declaration, and related help text were removed.
Simplify ARM64 container build
Containerfile
The upx-ucl package and binary compression command were removed.
Prepare uncompressed CI and release artifacts
.github/workflows/ci.yml, .github/workflows/release.yml
CI and release workflows now copy binaries directly to artifact names while retaining size listing and checksum generation.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: mangelajo

Poem

A rabbit hops past compressed bytes,
No UPX waits by build-time gates.
The binaries copy, plain and bright,
Checksums follow in steady flight.
“Less hopping!” cheers the moonlit hare.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: removing UPX compression from the build and release workflows.
Description check ✅ Passed The description is related to the change, stating the likely AArch64 segfault cause for removing UPX.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant