Improve parsing performance #62
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost a 100% performance improvement with these parsing changes, notably removing
.split()and removing.trim(), and using a loop instead of a regex to validate numbers. This is the rough order of optimization and improvement:Before:
Removing array assignment (use object return):
Validate number in loop and remove
.trim():Remove
.split()and use string slicing:The parser is fairly similar to
cookienow, so I knew the optimizations to make already. I think there's still something in the handling of missing values but it seems negligible for the effort.