refactor: use includes() instead of indexOf() for boolean checks#260
Closed
Ayoub-Mabrouk wants to merge 1 commit intojshttp:masterfrom
Closed
refactor: use includes() instead of indexOf() for boolean checks#260Ayoub-Mabrouk wants to merge 1 commit intojshttp:masterfrom
Ayoub-Mabrouk wants to merge 1 commit intojshttp:masterfrom
Conversation
Replace str.indexOf("%") === -1 with !str.includes("%") in decode function.
This improves readability and may have slight performance benefits as includes()
is optimized for boolean checks in modern JavaScript engines.
Member
|
While this seems true of V8, it looks like Safari results in a perf hit using includes. I'm not sure why, but it's 75% slower than |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace str.indexOf("%") === -1 with !str.includes("%") in decode function. This improves readability and may have slight performance benefits as includes() is optimized for boolean checks in modern JavaScript engines.