Splitting intro into two tutorials#714
Open
connorcartwright wants to merge 25 commits intojquery:mainfrom
Open
Splitting intro into two tutorials#714connorcartwright wants to merge 25 commits intojquery:mainfrom
connorcartwright wants to merge 25 commits intojquery:mainfrom
Conversation
order.json
Outdated
| "about-jquery": [ | ||
| "how-jquery-works", | ||
| "how-to-setup-jquery", | ||
| "using-jquery", |
Member
There was a problem hiding this comment.
There is a spacing problem here.
added 9 commits
June 17, 2016 00:54
Author
|
Hey @AurelioDeRosa Thank you for the feedback! I've updated the pages taking into account all of the changes you suggested 👍 I'll give the pages another read through soon to see if there's anything else that can be improved. |
Member
|
Let me know when you're done so that I can have a final look and then merge it. |
Author
|
Hey @AurelioDeRosa I've updated both pages a little bit, should be good to 🚢 |
order.json
Outdated
| "about-jquery": [ | ||
| "how-jquery-works", | ||
| "additional-support" | ||
| "how-to-setup-jquery", |
Member
There was a problem hiding this comment.
This is using tabs but we use spaces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #658
Closes #661
Hey guys @AurelioDeRosa @agcolom @gnarf @arthurvr
I'd like to continue on from #661 and hopefully get these new pages setup soon - I'll be giving them a good read through tomorrow (and double checking that all issues raised have already been amended) but any edits we want made I can do ASAP 👍
I've made a minor amend (fixing references to
main.jsthat should have beendemo.js) and hope to improve the files as much as possible.