Skip to content

Use Interlocked.Increment for thread-safe test counters #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 1 commit into from
Apr 2, 2026
+5 −2
Merged

Use Interlocked.Increment for thread-safe test counters #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions TestInstrumentation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,10 @@ public override void OnStart()

class ResultConsumer(Instrumentation instrumentation) : IDataConsumer
{
public int Passed, Failed, Skipped;
int _passed, _failed, _skipped;
public int Passed => _passed;
public int Failed => _failed;
public int Skipped => _skipped;
public string? TrxReportPath;

public string Uid => nameof(ResultConsumer);
Expand Down Expand Up @@ -90,7 +93,7 @@ FailedTestNodeStateProperty or ErrorTestNodeStateProperty
if (outcome is null)
return Task.CompletedTask;

_ = outcome switch { "passed" => Passed++, "failed" => Failed++, _ => Skipped++ };
_ = outcome switch { "passed" => Interlocked.Increment(ref _passed), "failed" => Interlocked.Increment(ref _failed), _ => Interlocked.Increment(ref _skipped) };

var id = node.Properties.SingleOrDefault<TestMethodIdentifierProperty>();
var b = new Bundle();
Expand Down