Thread limit introspection, part 2: Empirical observation in CI - #224
Conversation
…e misleading results
|
Looks like occasionally the output is erroneously "not sure", but mostly gets everything right. |
|
Is this PR still needed if we merge #228? |
|
I think so - the technique I use for testing in #228 is Linux-specific ( |
|
Ok, I'll add it to my review backlog. For Windows, feel free to take over or inspiration from this vibecoded proof of concept: #221. |
ogrisel
left a comment
There was a problem hiding this comment.
Some improvement suggestions but otherwise LGTM.
|
Note: I noticed that EDIT: I opened #231 to track that issue. |
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
…n-api' into 214-limit-semantics-introspection-api
|
OK I've addressed all review comments. |
|
Merged! Thanks again @itamarst. |
Fixes #214
In theory one could, say, distribute another package in PyPI/conda-forge of compiled OpenMP code so users can run this locally. Or I guess ... pick some part of e.g. scikit-learn that is unlikely to change but that seems brittle too. So this could be better, and maybe sometime it's worth doing that.
But at least it should run in CI and give us useful info, so it's a good first step.