Skip to content

fix: c++20 compilation#274

Closed
pminev wants to merge 2 commits intojinja2cpp:masterfrom
alpaca-core:pminev/fix-c++20
Closed

fix: c++20 compilation#274
pminev wants to merge 2 commits intojinja2cpp:masterfrom
alpaca-core:pminev/fix-c++20

Conversation

@pminev
Copy link

@pminev pminev commented Jan 24, 2025

There was an ambiguity for the format_to function since there is one in the srandart.

-- there is a compilation error if  the `-Wunused-parameter` compile flag is used
@nonifier
Copy link

nonifier commented Jun 5, 2025

Confirming that this is working and useful 👍🏼

@rmorozov
Copy link
Member

@pminev , @nonifier , thank you guys

I've made similar changes during my longtime refactoring in #279

closing this PR, feel free to reopen if problem persists

I've checked c++20 compilation on Mac llvm build, maybe it's good idea to such matrix configuration in GitHub CI

@rmorozov rmorozov closed this Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants