Open
Conversation
plopoyop
force-pushed
the
feature/git-plugin
branch
from
0470ad6 to
3ccb1fd
Compare
plopoyop
force-pushed
the
feature/git-plugin
branch
from
3ccb1fd to
ce503f2
Compare
Author
|
I just rebase my branch on main and fix lint |
- Switch example plugin URLs from git+ssh:// to git+https:// so tests pass in CI without SSH keys - Use Ref (branch/tag) for --branch flag instead of Rev (commit hash), since --depth 1 --branch doesn't work with arbitrary commit SHAs - Include Ref field in Hash() to avoid false duplicate detection when plugins differ only by ref
The testscript framework strips PATH to only the testscript bin dir, so the git binary isn't available when TestExamples runs devbox as a subprocess. The git plugin examples are already covered by TestDevbox shell plan tests which run in-process with the normal PATH.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement Git plugin support for loading plugins from any Git repository with revision/branch/directory targeting. Extends existing GitHub plugin functionality to support self-hosted and local Git repositories.
Fix #2048 in a more simple way than #2470 since there is no change in json schema
How was it tested?
Manually on a mock project with multiple transport : git+ssh, git+http, git+file
Community Contribution License
All community contributions in this pull request are licensed to the project
maintainers under the terms of the
Apache 2 License.
By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 License as stated in
the
Community Contribution License.