Enable { and } to change diff context size in branches and tags panels in diffing mode

[stefanhaller]

When looking at a diff in diffing mode in the branches or tags panels (e.g. after pressing W on a branch and then selecting a different branch to diff it against the first one) it wasn't possible to change the diff context size using { and }, or the rename threshold using ( and ).

Fixes #5254.

[codacy-production]

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation	Diff coverage
Report missing for 17e70441	✅ 87.50%

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (17e7044)	Report Missing	Report Missing	Report Missing
Head commit (9dd121d)	60199	52680	87.51%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#5258)	16	14	87.50%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Footnotes

1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct. ↩

[stefanhaller]

BTW, I'm a little undecided whether the code complexity is worth it actually. Given that the commands show a toast saying what they did, I could also see us enabling the commands unconditionally everywhere. You could then change the diff context size while looking at the status panel, but why not? It would take effect the next time you view a diff.

[goyalyashpal]

Given that the commands show a toast saying what they did,

... actually, i stumbled upon a case where it didn't, though i cant recall it right away.

do u want me to try to find that again?

I could also see us enabling the commands unconditionally everywhere. You could then change the diff context size while looking at the status panel, but why not?

i thought it was supposed to be the case already since these keybinds are listed under the "global" heading?

[stefanhaller]

I could also see us enabling the commands unconditionally everywhere. You could then change the diff context size while looking at the status panel, but why not?

i thought it was supposed to be the case already since these keybinds are listed under the "global" heading?

No, they are listed but don't do anything when a panel is focused that doesn't show diffs.

An alternative would be to strike them through in that case, with a tooltip explaining why they aren't available, like we do for many other commands that are only conditionally available. But I don't think it's worth the effort, it's just fine to enable them always.

[goyalyashpal]

stefanhaller enabled auto-merge 6 hours ago

what is auto-merge?

[stefanhaller]

It's a GitHub feature that merges the PR as soon as CI is green, so that I don't have to wait for that.