Closed
Conversation
4764307 to
98e99ed
Compare
2a38842 to
0e8c5a0
Compare
0e8c5a0 to
d5905bd
Compare
Mips2648
requested changes
Apr 16, 2026
Collaborator
Mips2648
left a comment
There was a problem hiding this comment.
Cet PR touche beaucoup trop de fichiers, il faut découper par bloc fonctionnel logique
je trouve cela trop compliqué à review en l'état.
De plus cela mix différents types de problèmes (supposés) avec des améliorations qui changent le comportement contrairement à ce que dit la description
Contributor
Author
|
En soit il n’y a vraiment pas de changement de comportement, c’est uniquement du dépilage de la baseline phpstan, mais je comprend tout à fait ta demande. Je vais découper proprement. |
This was referenced Apr 16, 2026
Collaborator
|
Ok thanks, I started to review the different PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Cette PR corrige les erreurs PHPStan détectées dans le code. Les modifications incluent :
cmd::dropInfluxDatabase(),cmd::historyInfluxAll())historyInfluxpar la création d'une tâche cron danshistoryInfluxAll()Ces corrections améliorent la qualité du code sans changer le comportement fonctionnel de l'application.
Suggested changelog entry
Correction des erreurs d'analyse statique PHPStan - amélioration de la qualité du code
Related issues/external references
N/A
Types of changes
PR checklist