Validate mapping key uniqueness#1221
Merged
SGSSGene merged 1 commit intojbeder:masterfrom Mar 12, 2026
Merged
Conversation
|
Would like to see this merged. It's a common source of problems to have duplicate keys in a map and have the content being overridden silently. We have huge config files with YAML and it's easy to miss an existing entry and duplicate it, causing issues due to the silent overriding. |
|
seconded... |
Collaborator
|
@brondani could you update this PR? I would like to merge it. |
brondani
force-pushed
the
validate-mapping-key-uniqueness
branch
from
45c6b77 to
486d7e7
Compare
Contributor
Author
Done. |
SGSSGene
approved these changes
Mar 12, 2026
Collaborator
|
Thank you! |
Contributor
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to YAML spec 1.2.2:
The changes proposed here check the uniqueness of scalar mapping keys, throwing a
NonUniqueMapKeyexception when by inserting a new key/value pair an identical scalar key is already present in a mapping. Non identical but equivalent scalar content, for example “0o13” (octal) or “0xB” (hexadecimal), are not considered.Address #60.